Page MenuHomePhabricator

$wgShowIPinHeader should be implied when using file or squid cache modes
Closed, ResolvedPublic

Description

Currently we just silently fail to cache things if $wgShowIPinHeader is on, which it is by default.

This is pretty lame and error-prone, since it's realllly easy not to realize you have to turn off this cosmetic setting to make caching work. I take full responsibility for making it work this way back in the early 2000s, but that was dumb of me. :)

We should just force it to off if eg $wgUseFileCache is in use, since that's the far more interesting/important setting.


Version: unspecified
Severity: enhancement
URL: http://lists.wikimedia.org/pipermail/wikitech-l/2009-January/041125.html

Details

Reference
bz17180

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:28 PM
bzimport set Reference to bz17180.

Done for $wgUseFileCache in r46372

Done in r46374 (after edit conflict)

Change 96691 had a related patch set uploaded by Persia:
Update comment in DefaultSettings for bug 17180

https://gerrit.wikimedia.org/r/96691

Change 96691 abandoned by Persia:
Update comment in DefaultSettings for bug 17180

Reason:
This is the wrong branch name, which is likely to be confusing to reviewers.

https://gerrit.wikimedia.org/r/96691

Change 96692 had a related patch set uploaded by Persia:
Update comment in DefaultSettings for bug 17180

https://gerrit.wikimedia.org/r/96692

Change 96692 merged by jenkins-bot:
Update comment in DefaultSettings for bug 17180

https://gerrit.wikimedia.org/r/96692