Page MenuHomePhabricator

PHP Fatal error: Call to a member function toHtml() on a non-object in /var/www/w/includes/ImagePage.php on line 921
Closed, ResolvedPublic

Description

PHP Fatal error: Call to a member function toHtml() on a non-object in /var/www/w/includes/ImagePage.php on line 921

The request URL was: /wiki/File:Wikimedia_Community_Logo.svg
Does not happen again when going to that URL, so it probably has to do something with caching.


Version: 1.15.x
Severity: normal

Details

Reference
bz17304

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:29 PM
bzimport set Reference to bz17304.
bzimport added a subscriber: Unknown Object (MLST).

Looks like this can happen if the transform call for the history line thumbnails fails.

Should be checking the return value on it.

Done in r46691. ForeignApiRepo::transform() already returns false on failure, so I threw a quick check to do the same into File::transform(). ImagePage now checks to see if $thumbnail is false before calling toHtml().