Page MenuHomePhabricator

use print <<<EOF in maintenance/importTextFile.php instead of 11 echos
Closed, ResolvedPublic

Description

maintenance/importTextFile.php print <<< patch

Here's a patch to use print <<<EOF in maintenance/importTextFile.php instead of 11 echos.

Consider doing the same in other scripts.

Also perhaps use echo basename(FILE) instead of hardwiring the file name into the usage message.

You can use \t's if you are worried the real tabs will get injured next edit or something.


Version: 1.13.x
Severity: trivial

Attached:

Details

Reference
bz17472

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:27 PM
bzimport set Reference to bz17472.
bzimport added a subscriber: Unknown Object (MLST).

By the way, not all the defaults are mentioned.

E.g., you say
--title <title>
Title for the new page; default is to use the filename as a base

But at
--user <user>
User to be associated with the edit
you don't cough up the default. Same for other options.

OK, thanks. But in the --help message do mention the defaults for each item.

(In reply to comment #3)

OK, thanks. But in the --help message do mention the defaults for each item.

Please provide a patch.