Page MenuHomePhabricator

Installer should honor &uselang= parameter
Closed, ResolvedPublic

Description

Also the Installer should honor the uselang= parameter in its URLs.

This can e.g. be handy when making screenshots for bug reports. ;-)


Version: 1.20.x
Severity: enhancement

Details

Reference
bz28296

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:36 PM
bzimport set Reference to bz28296.

There is already the UserLang parameter. Unfortunately the session language overrides this right now.

john wrote:

Allows for use of uselang parameter

attachment b28296.patch ignored as obsolete

Is there a reason we need two query params doing the same thing here?

john wrote:

(In reply to comment #3)

Is there a reason we need two query params doing the same thing here?

The UserLang parameter that was already there is for the initial language page and not intended to be used like requested in the bug. I thought it would also be more initiative to keep the style of the uselang param name from the rest of the software consistent here.

Then we could rename UserLang and just use uselang for both :)

john wrote:

Alternate method, replaces UserLang input field name with uselang so there's one parameter

Fair enough, this patch should take care of that

attachment b28296_p2.patch ignored as obsolete

sumanah wrote:

John, this patch is obsolete and no longer applies to trunk in SVN. Can you revise & commit?

sumanah wrote:

Comment on attachment 8835
Alternate method, replaces UserLang input field name with uselang so there's one parameter

Patch no longer applies to trunk, so marking obsolete (checked by Rusty per
http://lists.wikimedia.org/pipermail/wikitech-l/2011-November/056340.html ).