Page MenuHomePhabricator

Fatal Error if logged in
Closed, DeclinedPublic

Description

Author: BeckPotato

Description:
Using MediaWiki 1.16.2 on shared hosting.

Installed LiquidThreads in extensions directory, updated LocalSettings.php to run it.

When not logged in Wiki operates normally. When logged in returns:

Fatal error: Call to a member function numRows() on a non-object in /serveraddress/html/Installdir/extensions/LiquidThreads/classes/NewMessagesController.php on line 400

I rely on Entension:MaintenanceShell to run update.php as I don't have SSH access.

Have not been able to run update.php since it requires being logged in. Not sure if this Fatal error is related to lack of updated tables or not.


Version: unspecified
Severity: critical
OS: Windows Vista
Platform: PC
Whiteboard: aklapper-moreinfo

Details

Reference
bz28439

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 11:34 PM
bzimport set Reference to bz28439.
bzimport added a subscriber: Unknown Object (MLST).

LQT is currently being rewritten, so marking WONTFIX. If it
happens after the rewrite, open a new bug.

(In reply to comment #1)

LQT is currently being rewritten, so marking WONTFIX. If it
happens after the rewrite, open a new bug.

This isn't a "wontfix." Even if there were an active rewrite (which I don't believe there is), this is a legitimate bug in an actively supported, maintained, and deployed extension.

I don't think either of these two statements is correct, but you may
know something I don't:

“actively supported” — Is someone besides Andrew maintaining it?

If so, I'd like to know.  Andrew has been pretty clear that he
doesn't think it is worth his time to support LQT in its current
form.

“maintained” — Again, is this someone besides Andrew? Because he is

not maintaining LQT in its current form.

(In reply to comment #3)

I don't think either of these two statements is correct, but you may
know something I don't:

“actively supported” — Is someone besides Andrew maintaining it?

If so, I'd like to know.  Andrew has been pretty clear that he
doesn't think it is worth his time to support LQT in its current
form.

“maintained” — Again, is this someone besides Andrew? Because he is

not maintaining LQT in its current form.

Well, LiquidThreads has been around for several years and is deployed to a number of sites, including Wikimedia wikis. If support for LQTv1 is being completely dropped, it'd be nice if that were made explicit somewhere. I haven't seen anything to suggest that it is (and doing so obviously has consequences both for Wikimedia wikis and non-Wikimedia wikis).

In this case, someone has filed a bug about fatal errors popping up when they install an extension using a fairly recent version of MediaWiki. I doubt this user cares about a LiquidThreads rewrite, but I imagine they do care about having a properly working site. They've taken the time to file a bug report; it'd be nice if it weren't simply discarded.

It's not really a bug that LiquidThreads fails before being installed.

I get the cleaner error:
A database query syntax error has occurred from within function "NewMessages::newMessageCount". Database returned error "1146: Table 'user_message_state' doesn't exist (localhost)".

Your problem is needing the wiki to fix the broken wiki.

What you can do is modify LiquidThreads/classes/NewMessagesController.php
so that you add return; just below the line
static function newMessageCount( $user ) {

That will disable the checking for new messages in the yet-missing table, so you should be able to reach the MaintenanceShell extension and create the tables. Then remove the "return;" you added to restore the original functionality.

BeckPotato: Did the last comment help?

With regard to the status of LiquidThreads, see http://www.mediawiki.org/wiki/Extension:LiquidThreads

Unfortunately closing this report as no further information has been provided.

BeckPotato: Please feel free to reopen this report if you can provide the information asked for and if this still happens. Thanks!