Page MenuHomePhabricator

[Regression] MediaWiki:Filepage.css not loaded on repo itself
Closed, ResolvedPublic

Description

Wikimedia Commons has created [[commons:MediaWiki:Filepage.css]] and it's being loaded on all wmf-wikis[1], however it's not loaded on Commons itself at all!

I'm assuming this is a bug otherwise convert to enhancement request.

Krinkle

[1] Due to bug 28083 it was also loaded before this page was created, but that aside..


Version: 1.17.x
Severity: critical

Details

Reference
bz29277

Event Timeline

bzimport raised the priority of this task from to High.Nov 21 2014, 11:26 PM
bzimport set Reference to bz29277.
bzimport added a subscriber: Unknown Object (MLST).

(In reply to comment #0)

....and it's being
loaded on all wmf-wikis[1], ...

um... what?!

(In reply to comment #1)

(In reply to comment #0)

....and it's being
loaded on all wmf-wikis[1], ...

um... what?!

New feature. Idea is that files on the shared repo have description pages from the shared repo, but so far it was impossible to use anything but inline css on those pages. That was becoming a bit problematic, so Filepage.css was created with the idea that imagepages for images on the shared repo, also include a CSS page from the shared repo.

Now the issue is that this page is not automatically included on the shared repo itself.

(In reply to comment #2)

(In reply to comment #1)

(In reply to comment #0)

....and it's being
loaded on all wmf-wikis[1], ...

um... what?!

New feature. Idea is that files on the shared repo have description pages from
the shared repo, but so far it was impossible to use anything but inline css on
those pages. That was becoming a bit problematic, so Filepage.css was created
with the idea that imagepages for images on the shared repo, also include a CSS
page from the shared repo.

Now the issue is that this page is not automatically included on the shared
repo itself.

Where was this discussed? vague memories from the last time I saw this discussed is that we didn't want remote wikis touching locals ones (in any form).

Don't know what or where, but it's still not loaded. Maybe it got lost in merges ?

Moving to 1.19.0 as 1.18 is released.

There appears to be a workaround, and this doesn't seem like something that will affect a lot of small wikis, so I'm removing this as a 1.19 tarball release blocker.

Working correctly on MediaWiki 1.19; marking as FIXED.

Gilles raised the priority of this task from High to Unbreak Now!.Dec 4 2014, 10:21 AM
Gilles moved this task from Untriaged to Done on the Multimedia board.
Gilles lowered the priority of this task from Unbreak Now! to High.Dec 4 2014, 11:20 AM