Page MenuHomePhabricator

Log entries broken due to LogPage::actionText() calls to logs with $wgLogActionHandler function callbacks
Closed, ResolvedPublic

Description

Various (all?) revision deletion combinations involving the "Suppress data from administrators as well as others" option yield the following error:

<b>Warning</b>: call_user_func_array() expects parameter 1 to be a valid callback, function 'DeleteLogFormatter' not found or invalid function name in <b>C:\xampp\htdocs\w\includes\logging\LogPage.php</b> on line <b>296</b>


Version: 1.20.x
Severity: normal

Details

Reference
bz33167
ReferenceSource BranchDest BranchAuthorTitle
repos/releng/release!52mastermainladsgroupStop branching DoubleWiki extension
Customize query in GitLab

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 12:05 AM
bzimport set Reference to bz33167.

It'd be good to test this on enwiki.beta

Niklas, could you look at this 1.19 blocker?

Spoke with Aaron; he's going to comment on this further. There's more information in code review about this issue. Basically, this is more about logging generally than it is about RevDel

See r96546 CR comments. This doesn't effect regular (non-suppress) revision deletion because the $wgLogActionHandlers wildcards aren't checked in LogPage::actionText().

Just to let you know, I'm very busy during FOSDEM and few days after.

sumanah wrote:

Per conversation with RobLa, reassigning to Niklas.