Page MenuHomePhabricator

[Regression] mwstore:// URLs appear in various error messages
Open, MediumPublic

Description

In trunk after the FileBackend branch merge, many error messages related to files have mwstore:// URLs as message parameters. This risks being even more confusing than the "public" placeholder that I introduced in filerepo, which drew many complaints from users.

I think replacing the "mwstore://local-backend/local-public" prefix with a simple "..." by default would be less confusing to ordinary humans. For sysadmins, optionally converting the mwstore:// URLs to some backend-specific identifier (for example actual filesystem paths) would be a useful debugging tool.


Version: 1.20.x
Severity: normal

Details

Reference
bz34238

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:13 AM
bzimport set Reference to bz34238.
bzimport added a subscriber: Unknown Object (MLST).

Milestone 1.19.0 since these errors are mostly seen by non-Wikimedia users.

(In reply to comment #0)

I think replacing the "mwstore://local-backend/local-public" prefix with a
simple "..." by default would be less confusing to ordinary humans.

Maybe...I'd prefer to keep the container, in case a failed up was moving some file from one zone to another, likely with the same relative paths.

For sysadmins, optionally converting the mwstore:// URLs to some backend-specific
identifier (for example actual filesystem paths) would be a useful debugging
tool.

Can't we just use trigger_error() or something and put more descriptive paths in there (e.g. absolute FS paths or real swift paths)? This would aid in debugging without conflating UI errors with detailed errors for admin debugging.

Error logs should be better with r112347.

With r112347, this is hopefully good enough for most purposes. Will fix up right eventually. Taking off of Aaron since this he probably won't have time for this soon.

I got this when uploading a file on installation close to master (rMW55b5b9f52dad) and I got this:

Das Verzeichnis „mwstore://local-backend/local-public/e/e0“ konnte nicht angelegt werden, which is "directorycreateerror".

Note: As this has the 1.21.0 target milestone set (bumped from 1.20, bumped from 1.19), this would require some final cleanup as written in comment 4. If this does not happen in the next weeks, the Target Milestone will likely get removed.