Page MenuHomePhabricator

[Regression] There should not be a mismatch between html and stylesheet version
Closed, DeclinedPublic

Description

Example

Could be wontfixed if there's a sufficient work-around.

This is what was causing the "Jump to navigation" links to appear on cached pages after the 1.19 roll-out. Also when 1.17/Vector was introduced, this bug broke a gazillion pages by turning their layout into an ugly mess for ~ 30 days due to cache html and stylesheet references.

Fixable?


Version: 1.19
Severity: normal

Attached:

Screen_Shot_2012-02-19_at_12.34.52_AM.png (543×943 px, 188 KB)

Details

Reference
bz34504

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:11 AM
bzimport set Reference to bz34504.
bzimport added a subscriber: Unknown Object (MLST).

The 'fix' I think would be to do some time-traveling so that we ensure that old stuff gets delivered with old HTML. But I'm not sure how possible that is; if old styles are out of cache then we'll end up with the new styles/scripts even if we "ask" for the old one in the timestamp on the request.

Traditionally, we intend for new CSS to apply validly to old HTML to work around this problem. If new CSS doesn't fix old HTML, then you get problems until the old HTML vanishes from cache.

Is this bug tracking the 'jump to' link issue specifically (eg, fix the styles so they're hidden again!) or is that already resolved and this is a general issue/idea/question?

Probably the best thing to do would be to add CSS rules for back compat.

It looks like switching .mw-jump to #jump-to-nav in shared.css will resolve this. Not sure why a new class was added here and the styles split...

r112034 fixes the style so it should work with old pages, please merge/deploy.

Since the original symptom behind this bug report is fixed, we need to decide how we're going to dispose of the original suggestion. Should we "wontfix" or leave open?