not happening for 1.20 tarball.

I am new to mediawiki and foss.I would like to work on this bug as my first fix

i have found the solution, i am submitting a patch to review

http://www.rubular.com/r/tTdxPEE4QO
can someone review if it is the right solution

Change 193081 had a related patch set uploaded (by Rits):
T36801 Changed Function applyDiffStyle uses regexes which do not detect CSS classes appropriately

https://gerrit.wikimedia.org/r/193081

Wonderin if http://stackoverflow.com/questions/28572450/php-regex-matches-html-tags-contain-a-certain-class-name could be helpful?

Change 193081 abandoned by TTO:
T36801 Changed Function applyDiffStyle uses regexes which do not detect CSS classes appropriately

Reason:
No progress in 2 years.

https://gerrit.wikimedia.org/r/193081

How shall I write the testcase ? I looked in phpunit/includes, but couldn't find any similar ones. Any pointers would be great, thanks

@subins2000 you can create a file in tests/phpunit/unit/includes/FeedUtilsTest.php

Then you'd want something like

<?php

class FeedUtilsTest extends MediaWikiUnitTestCase {

  public function testApplyDiffStyle() {
   $someTestString = 'blahblah';
   $this->assertSame( 'whatyouexpect', FeedUtils::applyDiffStyle( $someTestString) );
  }

}

You can run the individual test with vendor/bin/phpunit tests/phpunit/unit/includes/FeedUtilsTest.php

Change 576444 had a related patch set uploaded (by Subins2000; owner: Subins2000):
[mediawiki/core@master] Update regex to match classes appropriately

https://gerrit.wikimedia.org/r/576444

@kostajh Thank you for your help :) I've made a patch. Hope it's fine and up-to the standards.

Is Core's includes/FeedUtils.php Growth or Core Platform Engineering territory?
In any case this contributed patch has been waiting for a review for eight months now...

In T36801#6611125, @Aklapper wrote:

Is Core's includes/FeedUtils.php Growth or Core Platform Engineering territory?

Looking at commits to that file, I don't see anything from current or past Growth team members.

In any case this contributed patch has been waiting for a review for eight months now...

It would be nice to surface this patch and others like it to the broader community of developers with +2 rights. There are many patches like this that theoretically are supposed to fall into some team's purview due to Developers/Maintainers but in practice they don't get reviewed since they don't relate at all to the team's day-to-day work or quarterly goals.

Thanks; removing team tag

Change 576444 merged by jenkins-bot:
[mediawiki/core@master] FeedUtils: Update regex to match classes appropriately, and test

https://gerrit.wikimedia.org/r/576444