Page MenuHomePhabricator

[Regression] $3 and $4 are not being substituted in {{urlencode:}} in message "movepage-moved"
Closed, ResolvedPublic

Description

The "revert" link for page moves produces a "no such target page" error message. It has been temporarily disabled on the English Wikipedia for that reason (see the above URL).


Version: 1.19
Severity: major
URL: http://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Revert_button_on_move_page_feature_doesn.27t_work

Details

Reference
bz34887

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 12:17 AM
bzimport set Reference to bz34887.
bzimport added a subscriber: Unknown Object (MLST).

Note that this link is not part of the software, it is message customization by en.wikipedia in <Movepage-moved>.

Original value: https://translatewiki.net/wiki/MediaWiki:Movepage-moved/en

Custom value (before it was (temporarily) taken out due to a bug): https://en.wikipedia.org/w/index.php?title=MediaWiki:Movepage-moved&action=edit&oldid=431525614

It uses the following wikitext to generate a link:

[{{fullurl:Special:Movepage|wpOldTitle={{urlencode:$4}}&wpNewTitle={{urlencode:$3}}&wpReason=revert&wpMovetalk=1}} revert]

As I've mentioned there [1], I don't think the error message is related to the revert-move link or this syntax in general or the new namespace selector. The following link syntax works fine, use this example for instance:

https://en.wikipedia.org/w/index.php?title=Special:MovePage&wpOldTitle=User:Krinkle/sandbox&wpNewTitle=Template_talk:Some_lovely_new_title&wpReason=revert&wpMovetalk=1

That works fine.

  • Krinkle

[1] https://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_(technical)&oldid=481432575#Revert_button_on_move_page_feature_doesn.27t_work

Leaning towards closure "WORKSFORME", can't reproduce this error.

Could be that the parameters to that interface message have changed.

I've just tested[1] this on en.wikipedia as it worked fine locally. However the bug is still very much there.

The link to revert it has raw urlencoded '$3' and '$4' in it, they are not being replaced as they should.

Rephrasing bug summary to reflect the problem.

  • Krinkle

[1] https://en.wikipedia.org/w/index.php?title=MediaWiki%3AMovepage-moved&diff=481438639&oldid=479665276