Page MenuHomePhabricator

Include unified diff in gerrit email notifications
Closed, ResolvedPublic

Description

Because the notifications are currently useless, they should be as they were in the system (example: http://thread.gmane.org/gmane.org.wikimedia.mediawiki.cvs/112867 ).


Version: unspecified
Severity: normal
See Also:
http://code.google.com/p/gerrit/issues/detail?id=1440

Details

Reference
bz35532

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 12:19 AM
bzimport added projects: Gerrit, Upstream.
bzimport set Reference to bz35532.

Checked on this upstream. Turns out it's already been fixed in master[0]. Will be released as part of 2.5, so marking this LATER until 2.5 is out and we determine a timeline for upgrading.

[0] https://gerrit-review.googlesource.com/#/c/34861/

Switching from LATER to the second most relevant resolution for fear of information loss. http://article.gmane.org/gmane.science.linguistics.wikipedia.technical/65116

There should now be diffs in your e-mails for new changes.

Hmm, not there. Need to poke this further (they *are* available)

We've now got diffs, gerrit change 49133.