Author: wilson.jim.r
Description:
Please make all members of all classes in the API either protected or public (not private), and remove all "const" declarations.
Examples:
- mModules in ApiMain.php - since it's private, changing any of the factory targets requires duplicating the entire class
- LIMIT_BIG1 and LIMIT_BIG2 in ApiBase.php - Extending classes should have the option of setting their own limits
Reasoning:
Keeping anything private means that to change it requires duplicating the entire class, or in some cases an entire class hierarchy. This encourages code duplication and hinders development by raising the level of work required both in development and maintenance.
I can provide more examples if necessary - this is a sweeping change.
Version: unspecified
Severity: normal