Page MenuHomePhabricator

LanguageCs.php updates
Closed, ResolvedPublic

Description

The LanguageCs.php file both in MediaWiki CVS and in Wikimedia installations contains many wrongly translated items, and many items are missing completely. The file at its current version is in fact unusable.

There is a much more up-to-date version at [[meta:LanguageCs.php]], and cs: Wikipedia has an up-to-date translation in its MediaWiki namespace.


Version: unspecified
Severity: enhancement

Details

Reference
bz1120

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 8:07 PM
bzimport set Reference to bz1120.
bzimport added a subscriber: Unknown Object (MLST).

Created attachment 420
LanguageCs.php for MediaWiki 1.4

Updated and corrected LanguageCs.php for MediaWiki version 1.4

Note: this is not a diff, but a complete file, since the version in CVS is _so_
outdated the diff is twice as big as the whole file.

I have tested the file on my local MediaWiki installation.

attachment LanguageCs_1.4.php ignored as obsolete

Created attachment 421
LanguageCs.php for MediaWiki 1.5

Updated and corrected LanguageCs.php for HEAD (MediaWiki version 1.5).

Note: this is not a diff, but a complete file, since the version in CVS is _so_
outdated the diff is twice as big as the whole file.

I have done some basic testing of the file on my local MediaWiki installation.

attachment LanguageCs_1.5.php ignored as obsolete

avarab wrote:

Hi.

When you plan to expand on an array, such as to add one bookstore to it do:

$wgBookstoreListCs = array(
'Národní knihovna' =>'http://sigm....'
) + $wgBookstoreListEn;

rather than what you currently do, this makes sure that if we ever add another
bookstore to the Language.php file it will propegate through the rest of them,
this also goes for skin names you didn't translate and other such arrays.

Furthermore, there's some redundant code in there, you specify
$wgMonthAbbreviationsCs but don't export it (the code is commented out), if you
plan not to use a piece of code please don't put it in the file.

Finally, why do you think you need checkTitleEncoding() ?

(In reply to comment #3)

When you plan to expand on an array [...]

OK, originally, I went along the lines of other LanguageXx.php files, but now I
see they have changed that recently; I have fixed that.

Furthermore, there's some redundant code in there, you specify
$wgMonthAbbreviationsCs but don't export it (the code is commented out), if you
plan not to use a piece of code please don't put it in the file.

Sorry for that, those were forgotten remnants.

Finally, why do you think you need checkTitleEncoding() ?

Well, I don't. The function has been there all the time since V_PHASE3REORG, I
just haven't touched it as I have no idea what is it good for.

Created attachment 423
LanguageCs.php for MediaWiki 1.4 and 1.5

updated LanguageCs.php (zip contains both versions)

attachment LanguageCs.zip ignored as obsolete

Created attachment 454
LanguageCs.php for 1.4

Some further little fixes and cleanup.

attachment LanguageCs_1.4.php ignored as obsolete

Created attachment 455
LanguageCs.php for MediaWiki 1.5

attachment LanguageCs_1.5.php ignored as obsolete

avarab wrote:

Removing patch keyword, they're not patches but full attachments.

Created attachment 593
LanguageCs.php diff for HEAD

a diff -u version instead of a full attachment (although it is just a
-everything, +everything)

attachment LanguageCs_1.5.php.diff ignored as obsolete

Created attachment 594
LanguageCs.php diff for the 1.4 branch

a diff -u instead of full attachment

attachment LanguageCs_1.4.php.diff ignored as obsolete

Created attachment 621
LanguageCs.php patch for the 1.5 branch

Two small (but important) fixes, +new items (esp. the Exif heap)

attachment LanguageCs.php.1.5.diff ignored as obsolete

avarab wrote:

(In reply to comment #11)

Created an attachment (id=621) [edit]
LanguageCs.php patch for the 1.5 branch

Two small (but important) fixes, +new items (esp. the Exif heap)

Applied with some changes to HEAD.

avarab wrote:

(In reply to comment #10)

Created an attachment (id=594) [edit]
LanguageCs.php diff for the 1.4 branch

a diff -u instead of full attachment

Applied to REL1_4

Created attachment 629
fix for two bugs in the 1.4 branch (one of them major)

The abovementioned 1.4 patch unfortunately contains two bugs:

  1. The NS_MEDIA namespace is wrongly duplicated with NS_IMAGE, so that _no

images work_!

  1. Javascript edit toolbar did not work because of quotes used instead of

apostrophes.

(The 1.5 version is correct.)

attachment LanguageCs.php.1_4.diff ignored as obsolete

avarab wrote:

(In reply to comment #14)

Created an attachment (id=629) [edit]
fix for two bugs in the 1.4 branch (one of them major)

The abovementioned 1.4 patch unfortunately contains two bugs:

  1. The NS_MEDIA namespace is wrongly duplicated with NS_IMAGE, so that _no

images work_!

  1. Javascript edit toolbar did not work because of quotes used instead of

apostrophes.

(The 1.5 version is correct.)

Applied to REL1_4

Created attachment 1311
LanguageCs.php diff against current HEAD, i.e. 1.82

Update of the Czech translation

attachment LanguageCs.php.diff ignored as obsolete

robchur wrote:

Reopening to reflect new patch.

rowan.collins wrote:

Committed; it looked sane enough to me. I also uncommented the "magic words"
array, because I couldn't see why it was like that - I hope there wasn't a good
reason!

Created attachment 1689
Updates to MessagesCs.php (r14115)

attachment MessagesCs.php.diff ignored as obsolete

robchur wrote:

Applied to SVN trunk, r14119.

Created attachment 1928
Updates to MessagesCs.php and LanguageCs.php

Implementation of plural and its use in messages, plus a few fixes, updates,
corrections, cleanup etc.

attachment langcs.diffs ignored as obsolete

Following messages failed to apply:
+ 'matchtotals' => 'Zadanému „$1“ odpovídá $2 {{plural:$2|název strany|názvy
stran|názvů stran}} a text $3 {{plural:$3|stran$
+ 'nogomatch' => ' Neexistuje žádná stránka s názvem „$2“. Můžete tuto
stránku [[$1|založit]].',

Rest in 14771.

Created attachment 2427
Updates to LanguageCs.php and MessagesCs.php

updates, fixes to Czech translation of MW

attachment CsUpdates.diff ignored as obsolete

Reopening for the new update (and changing summary a bit).

jimmy.collins wrote:

Applied to r16722. Please open a new bug the next time.

Thank you!

Created attachment 2428
Two more fixes

Two more fixes: restorelink and undeletedrevisions-files

Attached:

jimmy.collins wrote:

(In reply to comment #28)

Created an attachment (id=2428) [edit]
Two more fixes

Two more fixes: restorelink and undeletedrevisions-files

In r16723.