Page MenuHomePhabricator

DatabasePostgres.php does not quote all schema names
Closed, ResolvedPublic

Description

Author: jh

Description:
Necessary changes to DatabasePostgres.php

To support schema names containing dashes (like "my-cool-schema"), the schema name has to be double-quoted in SQL statements.
Throughout DatabasePostgres.php this is done by using the quote_ident() function.

But there is one missing spot: In setup_database(), while testing the writeability of the schema,
$wgDBmwschema is used unquoted in SQL statements, leading to errors.

The diff is attached.

Regards,
Jutta


Version: 1.11.x
Severity: normal

Attached:

Details

Reference
bz11952

Related Objects

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
InvalidNone
ResolvedNone

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 9:58 PM
bzimport set Reference to bz11952.
bzimport added a subscriber: Unknown Object (MLST).

Thanks, applied patch plus some other similar problems in r28214

Jdforrester-WMF subscribed.

Migrating from the old tracking task to a tag for PostgreSQL-related tasks.