Author: carlb613

Description:
Edit links are appearing below the section header line instead of above it. This is interfering with formatting of some pages, as it can push text into a position where it is overlapped by images.

This appears to be the result of a one-line change in Linker.php; 1.12alpha (r28587) line 1228 has in public function makeHeadline( $level, $attribs, $anchor, $text, $link ):

return "<a name=\"$anchor\"></a><h$level$attribs<span class=\"mw-headline\">$text</span>$link </h$level>";

Changing the order of these elements puts things back the way they were:

return "<a name=\"$anchor\"></a>$link <h$level$attribs<span class=\"mw-headline\">$text</span></h$level>";

So far, this has been tested only on uncyclopedia.tw and uncyclopedia.hk (regular-script Chinese, zh-tw) but I'd expect the same results once the change is applied to others.

Was this change made by accident or by design? -- en:user:carlb

The original HTML problem (as reported to me) was this:

The original code is:

<h2><span class="editsection">
[<a href="/index.php?title=aaa&action=edit&section=15" title="編輯段落: aaa">編輯</a>]
</span><span class="mw-headline">aaa</span </h2>

Now becomes:

<h2><span class="mw-headline">aaa</span>
<span class="editsection">[<a href="/index.php?title=aaa&action=edit&section=15" title="編輯段落: aaa">編輯</a>]
</span> </h2>

This cause some layout problems. --Leeyc0 10:00, 18 December 2007 (UTC)

Version: 1.12.x
Severity: minor
URL: http://encyclopedia.tw/wiki/%E8%AC%9B%E5%80%92%E7%B7%9A?action=purge