Page MenuHomePhabricator

add garish CSS to use mw-anon-edit-warning
Closed, DeclinedPublic

Description

Simetrical> I've added the ID mw-anon-edit-warning in r28786.
That should be CLASS not ID.
Also the PREVIEW pages should have the warning too, as they might have
missed it on the first edit page.


Version: 1.12.x
Severity: enhancement

Details

Reference
bz12474

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 9:58 PM
bzimport set Reference to bz12474.
bzimport added a subscriber: Unknown Object (MLST).

ayg wrote:

You seem to have two separate requests, not one:

  1. The mw-anon-edit-warning ID should become a class. Why do you want this? IDs work just as well as classes for CSS.
  1. Preview pages should have the warning too. Debatable whether this is needed, I don't really think so enough to do this. You got the message once, I don't want to clutter the top of the screen with unneeded info.

All I know is that in ~/.mozilla/firefox/*.default/chrome/userContent.css,
the last line of

/* Wikipedia: */
a.new { background-color: silver; }
a.stub { background-color: grey; }
div.mw-anon-edit-warning { background-color: orange; text-decoration: underline; }

only worked if I edited the rendered HTML to say class and not id.

Sorry for not making two bugs. There is a 25% chance users will notice the message upon each refresh... decreasing into the heat of the edit... 25+20+15+10... the will notice it sooner or later hopefully before they hit Save.

Best would be background "Edit Edit" slanted as in other wikis, and even "not logged in ... edit..." Wait, I don't let anything other than the HTML past WWWOFFLE, so, Your (judgement) call here. Better yet: electrodes to the balls...

Changing div.mw-anon-edit-warning to div#mw-anon-edit-warning or just #mw-anon-edit-warning (i.e. change the dot to a pound sign) fixes this.

ayg wrote:

(In reply to comment #2)

All I know is that in ~/.mozilla/firefox/*.default/chrome/userContent.css,
the last line of

/* Wikipedia: */
a.new { background-color: silver; }
a.stub { background-color: grey; }
div.mw-anon-edit-warning { background-color: orange; text-decoration:
underline; }

only worked if I edited the rendered HTML to say class and not id.

Because your CSS selector is for a class, not an ID. It needs to use #mw-anon-edit-warning, as Roan says.

Sorry for not making two bugs. There is a 25% chance users will notice the
message upon each refresh... decreasing into the heat of the edit...
25+20+15+10... the will notice it sooner or later hopefully before they hit
Save.

I don't agree with the necessity of this. We already have extra lines of content up at the top on preview, I'm not inclined to add more. If the notice isn't visible enough on the first edit, it probably won't be visible enough on subsequent edits. Marking WONTFIX, as far as I'm concerned, although if some other developer disagrees and wants to implement this, they can reopen and that's their business.

OK anyway, now that there is a style, can you please begin to use it in the skins.
Perhaps not as garish as
div#mw-anon-edit-warning { background-color: orange; text-decoration: underline; }
but something at least.

You see just today. a beloved user on my wiki has mistakenly edited while not logged in,
leaving his company's IP address in the history of A_Sensitive_Article
and RecentChanges, etc. Now he is imploring me to expunge his IP.
I could say "didn't you see the warning in garish orange?" if only it were...
Yes I could hack it for my wiki but I'm sure this is a common problem.

That's exactly what common.css is for:
For CSS that's not appropriate in every MW install, but in yours.