Page MenuHomePhabricator

Invalid XHTML rendered during edit conflict
Closed, ResolvedPublic

Description

Author: willemo

Description:
The following HTML fragment is rendered during an edit conflict:

<textarea tabindex=6 id='wpTextbox2' name="wpTextbox2" rows='25' cols='80' wrap='virtual'>

Two issues:

  • tabindex attributes lacks quotes
  • wrap='virtual' seems to be invalid XHTML according to the XHTML check of validator.w3.org

Probably the following line in EditPage.php needs to be changed from:

$wgOut->addHTML( "<textarea tabindex=6 id='wpTextbox2' name=\"wpTextbox2\" rows='{$rows}' cols='{$cols}' wrap='virtual'>"

into:

$wgOut->addHTML( "<textarea tabindex='6' id='wpTextbox2' name=\"wpTextbox2\" rows='{$rows}' cols='{$cols}'>"

(not sure about wrap, though)

I admit this is quite an unusual use case. Error is found in svn trunk yesterday.


Version: unspecified
Severity: trivial

Details

Reference
bz12553

Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 21 2014, 10:02 PM
bzimport set Reference to bz12553.
bzimport added a subscriber: Unknown Object (MLST).