Page MenuHomePhabricator

Unprotecting a non-protected page leaves a log entry
Closed, ResolvedPublic

Description

It's possible to "unprotect" a page without protection ever having been set. If you use &action=unprotect on a page and confirm the protection, it leaves a log entry.

Generally this wouldn't really matter, however, people sometimes use scripts and they accidentally hit the wrong button / link, causing an awkward log entry.


Version: unspecified
Severity: enhancement
URL: http://en.wikipedia.org/w/index.php?title=Special%3ALog&type=protect&user=&page=User%3AMZMcBride%2FSandbox+7

Details

Reference
bz12716

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:07 PM
bzimport set Reference to bz12716.
bzimport added a subscriber: Unknown Object (MLST).

overlordq wrote:

change to Title.php

A change similar to r30020 to check the return of the SQL UPDATE/DELETE of Title Protection should fix this?

Tests 1-4 before patch, tests 5-12 after.
http://www.thedarkcitadel.com/w/index.php?title=Special:Log&page=Sandbox

Attached:

sxwiki wrote:

Confirmed this behavior on my testwiki, and, confirmed the patch as working.

REOPENED

Still having this issue. See http://en.wikipedia.org/w/index.php?title=Special%3ALog&type=protect&user=&page=User+talk%3ARjd0060%2Ftest&year=&month=-1 .

I set an expiry and a protection reason and clicked confirm, which logged the unprotection, even though the page was never protected.