Page MenuHomePhabricator

Wrong archive URL in FileDeleteForm::prepareMessage()
Closed, ResolvedPublic

Description

Running r30403 on WMF wikis and trunk local:

FileDeleteForm.php:

private function prepareMessage( $message ) {
...
return wfMsgExt(
"{$message}-old",
'parse',
$this->title->getText(),
$wgLang->date( $this->getTimestamp(), true ),
$wgLang->time( $this->getTimestamp(), true ),
$wgServer . $this->file->getArchiveUrl( $this->oldimage )

The last line creates a wrong URL on projects with a shared repository like Commons (see URL in bug):
http://commons.wikimedia.orghttp//upload.wikimedia.org/wikipedia/commons/archive/8/8e/20080121185103%21Ecce_Homo_-_Eichenholzrelief_-_Kolumba_K%C3%B6ln.jpg


Version: 1.12.x
Severity: normal
URL: http://commons.wikimedia.org/w/index.php?title=Image:Ecce_Homo_-_Eichenholzrelief_-_Kolumba_K%C3%B6ln.jpg&action=delete&oldimage=20080121185103%21Ecce_Homo_-_Eichenholzrelief_-_Kolumba_K%C3%B6ln.jpg

Details

Reference
bz12935

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:07 PM
bzimport set Reference to bz12935.
bzimport added a subscriber: Unknown Object (MLST).
  • Bug 12981 has been marked as a duplicate of this bug. ***