Page MenuHomePhabricator

PATCHES - moving Wikimedia only stuff from LanguageXx.php to InitialiseSettings.php
Closed, ResolvedPublic

Assigned To
None
Authored By
Danny_B
May 27 2008, 2:28 PM
Referenced Files
F5011: LanguageBe.php.patch
Nov 21 2014, 10:15 PM
F5010: LanguageHsb.php.patch
Nov 21 2014, 10:15 PM
F5012: LanguageBe_tarask.php.patch
Nov 21 2014, 10:15 PM
F5008: wgGrammarForms-hsb
Nov 21 2014, 10:15 PM
F5009: LanguageDsb.php.patch
Nov 21 2014, 10:15 PM
F5006: LanguageBs.php.patch
Nov 21 2014, 10:15 PM
F5007: wgGrammarForms-dsb
Nov 21 2014, 10:15 PM
F5004: wgGrammarForms-be-tarask
Nov 21 2014, 10:15 PM

Description

Removing Wikimedia only stuff from LanguageCs.php, + some doc

Per bug 14165 moving Wikimedia only stuff from LanguageCs.php to InitialiseSettings.php.

The patch to LanguageCs.php must not be applied before the patch to InitialiseSettings.php is done, otherwise live wikis will loose the proper {{grammar:}} function


Version: unspecified
Severity: enhancement

Attached:

Details

Reference
bz14294

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:15 PM
bzimport set Reference to bz14294.
bzimport added a subscriber: Unknown Object (MLST).

Moving Wikimedia only stuff to InitialiseSettings (wgGrammarForms)

Attached:

Created attachment 5135
wgGrammarForms for 'be'

Adding $wgGrammarForms for 'be'. Should be removed from LanguageBe.php after configuration.

Attached:

Created attachment 5136
wgGrammarForms for 'be-tarask'

Attached:

Created attachment 5137
wgGrammarForms for 'bs'

Also see LanguageBs.php.patch to cleanup LanguageBs.php after using this configuration.

Attached:

Created attachment 5138
Cleanup for LanguageBs.php after wgGrammarForms for 'bs'

Attached:

Created attachment 5139
wgGrammarForms for 'dsb'

Attached:

Created attachment 5140
wgGrammarForms for 'hsb'

Attached:

Created attachment 5141
Cleanup for LanguageDsb.php after wgGrammarForms for 'dsb'

Attached:

Created attachment 5142
wrong

attachment wrong ignored as obsolete

Created attachment 5143
Cleanup for LanguageHsb.php after wgGrammarForms for 'hsb'

Attached:

Created attachment 5144
Cleanup for LanguageBe.php after wgGrammarForms for 'be'

Attached:

Created attachment 5145
Cleanup for LanguageBe_tarask.php after wgGrammarForms for 'be-tarask'

Attached:

Brion suggested a different, probably better solution, that is also much easier for Wikimedia shell operators: add all this stuff to the extension WikimediaMessages, and as a consequence, remove the section 'wgGrammarForms' from http://noc.wikimedia.org/conf/InitialiseSettings.php.html.

I have already made all necessary changes to files on my local system. Will discuss this on IRC when brion, Tim, or JeLuF is available.

Fixed in r39077.

  • (bug 14165, bug 14294) Wikimedia specific configuration in convertGrammar() for 13 localisations (be, be-tarask, bs, cs, dsb, ga, gsw, hsb, hu, lv, rmy, sk, sl) removed. The settings have been put in extension WikimediaMessages. For be, be-tarask, bs, dsb, hsb some duplicates (1=1) were removed. Patch for Czech by Danny B.
  • Also put the wgGrammarForms from the Wikimedia configuration in here, so everything is in one place. Bonus with this setup is that there will be a little less work for Wikimedia shell operators, as the wgGrammarForms configuration is now accessible to i18n committers.
  • Header for WikimediaMessages.php, and add myself to extension credits.

WARNING to Wikimedia shell operators: the whole section "wgGrammarForms" in InitialiseSettings.php.html should be remove after updating to this version. It will most probably overrule all settings in WikimediaMessages because of "'default' => array()"