Page MenuHomePhabricator
Create Task
Maniphest T16778

PageHistory don't use limit
Closed, ResolvedPublic
Actions

Description

Author: chantepie

Description:
PageHistory patch

PageHistory don't use limit request parameter.

Version: 1.12.x
Severity: normal

Attached:

PageHistory.wgFeedLimit.patch284 BDownload

Details

Reference
bz14778

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:11 PM
• bzimport added a project: MediaWiki-Page-diffs.
• bzimport set Reference to bz14778.
• bzimport added a subscriber: Unknown Object (MLST).
• bzimport created this task.Jul 10 2008, 7:54 AM
• demon added a comment.Jul 10 2008, 2:53 PM

Done in r37508

FunPika added a comment.Jul 10 2008, 9:38 PM

Reverted in r37536 by Brion

• bzimport added a comment.Jul 11 2008, 7:22 AM

chantepie wrote:

(In reply to comment #2)

Reverted in r37536 by Brion

Why ?

Nikerabbit added a comment.Jul 11 2008, 7:26 AM

Clicking the link would have told you:
Revert r37508 for now ((bug 14778) 'limit' parameter now applies to history feeds as well as history pages)
The $limit parameter isn't validated properly as a limit, and is passed to the database producing an SQL error if negative.

• demon added a comment.Jul 15 2008, 4:01 PM

Reimplemented in r37699, no longer allows negatives.

Aklapper added a project: MediaWiki-Page-history.Sep 20 2019, 7:48 PM
Aklapper removed a subscriber: • wikibugs-l-list.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL