Page MenuHomePhabricator

Punjabi languagexx.php needs to be made live (was:Punjabi languagexx.php file update)
Closed, ResolvedPublic

Description

Author: node.ue

Description:
The file LanguagePa.php needs to be updated sometime, at your soonest convenience.


Version: unspecified
Severity: blocker

Details

Reference
bz1478
TitleReferenceAuthorSource BranchDest Branch
Feed Druid unique devices dataset from Iceberg tablerepos/data-engineering/airflow-dags!582aquT347879_unique_devices_iceberg_to_druid_task_sensormain
Start branching WikimediaCampaignEvents for Wikimedia productionrepos/releng/release!57daimonaT347894main
Unique devices druid ingestion job - Iceberg migrationrepos/data-engineering/airflow-dags!564aquT347879_unique_devices_iceberg_to_druidmain
Draft: Add version print optionrepos/sre/purged!2brettchange-962670-add-version-print-optionmain
Change badrevid retry logic: retry on recent eventsrepos/data-engineering/mediawiki-event-enrichment!74ottoT347884-retry-badrevid-on-recentmain
mw-page-content-change-enrich should not retry on badrevids if no replica lagrepos/data-engineering/mediawiki-event-enrichment!72ottoT347884-only-retry-if-lagmain
Customize query in GitLab

Revisions and Commits

Event Timeline

bzimport raised the priority of this task from to Unbreak Now!.Nov 21 2014, 8:11 PM
bzimport set Reference to bz1478.
bzimport added a subscriber: Unknown Object (MLST).

Please attach patches for HEAD and REL1_4

node.ue wrote:

Actually, there is no LanguagePa.php yet in CVS, so
http://meta.wikimedia.org/wiki/LanguagePa.php is the first version.

zigger wrote:

*** Bug 1517 has been marked as a duplicate of this bug. ***

sukhuk wrote:

Punjabi Language PHP

attachment LanguagePa.php ignored as obsolete

jeluf wrote:

This file does not work with recent versions of MediaWiki.
Please use the 1.4 branch for starting new language files.

node.ue wrote:

(In reply to comment #5)

This file does not work with recent versions of MediaWiki.
Please use the 1.4 branch for starting new language files.

I am not sure what is different, I already attempted previously to fix this
file. Can you tell us what is wrong so we can fix the existing language file
rather than starting from "scratch"?

sukhuk wrote:

Punjabi Language PHP - V2

I've attempted to update this using the latest version from the CVS. I think
it's right - but to be honest, I'm not sure what I'm doing :D

attachment LanguagePa.php ignored as obsolete

sukhuk wrote:

Punjabi Language PHP - V2.1

Found a bug in the language file... fixed

attachment LanguagePa.php ignored as obsolete

node.ue wrote:

(normal function on pa.wiki impossible)

sukhuk wrote:

Hi,

What's the status with this update?

avarab wrote:

A LanguagePa.php file that works.

I took the 2.1 version here and fixed the bugs in it (it had 2 fatal syntax
errors), and simplified it a lot, I deleted a lot of the untranslated messages
and commented out others so that they're inherited from Language.php now (as
they should be).

It WorksForMe™ on my box running the HEAD branch, it *should* most definitely
work on REL1_4 but I haven't tried it on that.

What sukhjinder_sidhu@hotmail.com might want to tell us is how he wants the
linktrail to be, currently this is:
"linktrail" => "/^([a-z]+)(.*)$/sD"
The linktrail is, the regular expression matched on links that tells the
software when to expand on link patterns, so in short it turns this:
[[foo]]bar
into this:
[[foo|foobar]]
however as soon as it encounters something other than a to z in the English
alphabet it ceases to work:
[[foo]]xxææxxx becomes [[foo|fooxx]]ææxxx

So, do you want any other characters inside that expression to expand on,
German for example has: /^((?:ä|ö|ü|ß|[a-z])+)(.*)$/sD to accommodate its
special characters.

However you might not want this at all, this works for Germanic languages but
might not be applicable to Punjabi at all, perhaps it doesn't form plurals by
adding suffixes (.e.g. [[bridge]]s) or in any other way contain something you
want to link to at the beginning of a word but not at the end of it.

In any case this can be fixed later, it's no big issue if it doesn't get into
this particular revision

attachment LanguagePa.php ignored as obsolete

jeluf wrote:

These functions are obsolete:
function getMonthName( $key )
{

		global $wgMonthNamesPa;
		return $wgMonthNamesPa[$key-1];

}

function getWeekdayName( $key )
{

		global $wgWeekdayNamesPa;
		return $wgWeekdayNamesPa[$key-1];

}

They have been converted to use wgAllMessages instead.

sukhuk wrote:

Punjabi Language PHP - V3

Phew, after lots of work I have cleaned it up even more. Sorted out the tabing
to make it easier to maintain. I've also stripped out all hardcoded references
to Wikipedia and tried to make it more in tune with the contents of
Language.php.

Sukh

attachment LanguagePa.php ignored as obsolete

avarab wrote:

Cleanup, extra translations etc.

This is a much more cleaned up version, sukh will have to translate the extra
arrays I added ( wgQuickbarSettingsPa, wgSkinNamesPa ).

attachment LanguagePa.php ignored as obsolete

avarab wrote:

LanguagePa.php

  • linktrail works.
  • Merged translations from "Punjabi Language PHP - V3"
  • Removed redundant code that didn't do anything.

This should no be good enough (perfect?) to apply it to the live Wikipedia.

attachment LanguagePa.php ignored as obsolete

sukhuk wrote:

Can anyone out there add this to the CVS?

sukhuk wrote:

LanguagePa.php

Adds the days of the week and month names that were taken out :/

attachment LanguagePa.php ignored as obsolete

node.ue wrote:

Tim,

As I may have stated before, my logic for the priority is as follows (amusing
that you change the priority and then just skip the bug):

There are a number of people clearly interested in participating in this
Wikipedia, and their participation depends primarily on the implementation of a
localised interface.

This has been waiting for quite some time now. I have asked numerous times in
MediaWiki-General over a number of months, but nobody was there at those times. I have
added it to the request page, to no avail. I have even coordinated with
Sukhjinder Sidhu.

Most recently I added it as a bug in bugzilla because that was suggested on
wikipedia-l.

If you are not willing to fix it yourself, please do not change the priority and
skip over it.

avarab wrote:

LanguagePa.php; \r\n => \n (converted windows file endings to unix ones)

Converted Windows newlines to unix newlines.

Attached:

Ahhhh, nice! Unlike many language files we receive, this file actually is valid PHP and compiles and runs! :)))))))

I've made some corrections to the linktrail, trimmed the untranslated messages, fixed a couple hardcoded localized
'Special:' namespaces, and swapped some {{ns:4}}:s for Project:s. Committed to REL1_4 and HEAD and put live.

Diffusion added a commit: Unknown Object (Diffusion Commit).Mar 4 2015, 8:22 AM