Page MenuHomePhabricator
Create Task
Maniphest T17579

clshow considers all categories !hidden
Closed, ResolvedPublic
Actions

Description

The clshow parameter for prop=categories seems to consider all categories as being not hidden, or else the API's definition of "hidden" isn't what is shown as "Hidden categories" at the bottom of the article page. For example, the following query should return at least one category for every page returned since it is querying the categories of pages in a hidden category:

http://en.wikipedia.org/w/api.php?action=query&generator=categorymembers&gcmtitle=Category:Pages_with_incorrect_ref_formatting&prop=categories&cllimit=max&clshow=hidden

However, at least in revision r40356, no categories are returned. All the categories, even the hidden one, are returned when !hidden is requested:

http://en.wikipedia.org/w/api.php?action=query&generator=categorymembers&gcmtitle=Category:Pages_with_incorrect_ref_formatting&prop=categories&cllimit=max&clshow=!hidden

I notice that OutputPage.php does the "hidden category" thing in a completely different way.

Version: unspecified
Severity: normal

Details

Reference
bz15579

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedCatropeT17579 clshow considers all categories !hidden
 DeclinedtstarlingT17191 cat_hidden field isn't used

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:19 PM
• bzimport added a project: MediaWiki-Action-API.
• bzimport set Reference to bz15579.
Anomie created this task.Sep 12 2008, 4:49 PM
Catrope added a comment.Sep 12 2008, 7:13 PM

Caused by bug 15191, but there seem to be no plans to fix it. I'll run the check against the page_props table, then.

• bzimport added a comment.Oct 20 2008, 2:05 PM

Bryan.TongMinh wrote:

There have to be some nasty LEFT JOINs. Something with

LEFT JOIN page ON (NS_CATEGORY, cl_to) = (page_namespace, page_title) LEFT JOIN page_props ON pp_page = page_id AND pp_propname = 'hidden' WHERE ...

Not nice.

Anomie added a comment.Dec 14 2008, 5:19 PM

Created attachment 5580
This should implement the query discussed in bug 15191

This patch should implement the query discussed in bug 15191:

SELECT /*! STRAIGHT_JOIN */ cl_from,cl_to FROM categorylinks LEFT JOIN page ON
page_namespace = '14' AND page_title = cl_to LEFT JOIN page_props ON pp_page =
page_id AND pp_propname = 'hiddencat' WHERE cl_from IN ('85', '92', '111',
'138') AND pp_propname IS NOT NULL ORDER BY cl_from, cl_to;

Attached:

x2.diff1 KBDownload

Catrope added a comment.Dec 14 2008, 5:40 PM

Modified patch applied in r44585.

Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:43 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL