Page MenuHomePhabricator

HTML comments in wikitext can cause extra spaces in rendered HTML
Closed, ResolvedPublic

Description

Author: silsor

Description:
Wikitext such as:

Madge then purchased mercuric chloride tablets under the guise of shopping for
something else, <!-- my sources disagree whether it was a hat or makeup --silsor -->
and consumed them in another attempt at [[suicide]].

can result in two spaces being visibly rendered in the HTML, one of which is a
&#160; as follows:

Madge then purchased mercuric chloride tablets under the guise of shopping for
something else,&#160; and consumed them

This is a bug because the default behaviour of HTML rendering agents is to ignore
extra whitespace, but the presence of the &#160; prevents this.


Version: 1.4.x
Severity: minor
URL: http://en.wikipedia.org/wiki/Madge_Oberholtzer

Details

Reference
bz1569
TitleReferenceAuthorSource BranchDest Branch
d/changelog: bump to 0.0.15repos/cloud/toolforge/builds-cli!63raymond-ndibebump_versionmain
[envvars-api] add messages to all responsesrepos/cloud/toolforge/envvars-api!25raymond-ndibeadd_messages_to_all_responsemain
Retry on 503 from ESrepos/search-platform/cirrus-streaming-updater!115pfischerretry-503main
[builds-cli] remove unused coderepos/cloud/toolforge/builds-cli!59raymond-ndibeminor_refactormain
d/changelog: bump to 0.0.14repos/cloud/toolforge/builds-cli!58raymond-ndibebump_to_0.0.14main
Allow overriding max. bulk request sizerepos/search-platform/cirrus-streaming-updater!112pfischeres-sink-configurationmain
Do not fail over leftover bytes during deserializationrepos/search-platform/cirrus-streaming-updater!111pfischerfix-es-writer-deserializationmain
Handle faulty indices, by synchronizing timeoutsrepos/search-platform/cirrus-streaming-updater!107pfischeres-response-timeoutmain
builds_cli: Adapt to messages in responsesrepos/cloud/toolforge/builds-cli!57dcarouse_wrapped_responsesmain
Add messages to all responsesrepos/cloud/toolforge/builds-api!81dcarowrap_responsesmain
gitlab_runner: upgrade to v16.6.2repos/releng/gitlab-cloud-runner!328jeltoupgrade-gitlab-runner-16.6main
scripts: Update version references in README.md during releaserepos/releng/blubber!71dduvallmain-I6e35b70d393526c5ce7794f6db6310d3a7abb773main
Use blubber v0.21.1 to build blubberrepos/releng/blubber!70dduvallmain-If3207447819fa157fc816b13c85d1b0b20b56c32main
Show related patches Customize query in GitLab

Revisions and Commits

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 8:12 PM
bzimport added a project: MediaWiki-Parser.
bzimport set Reference to bz1569.
bzimport added a subscriber: Unknown Object (MLST).

This is fixed in cvs.

There is still a double space cause there is one before and after
the comment block which is correct behaviour. &#160; no more
generated.

epriestley added a commit: Unknown Object (Diffusion Commit).Mar 4 2015, 8:24 AM
epriestley added a commit: Unknown Object (Diffusion Commit).