Page MenuHomePhabricator

API: list=recentchanges doesn't allow to query patrolmarks even if user has the patrolmarks right
Closed, ResolvedPublic

Description

ApiQueryRecentChanges checks only for 'patrol' permission, when rcprop=patrolled is given, instead it should use $wgUser->useRCPatrol(), which checks all related rights.


Version: 1.14.x
Severity: trivial
URL: http://en.wikipedia.org/w/api.php?action=query&list=recentchanges&rcprop=patrolled

Details

Reference
bz15945

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:22 PM
bzimport set Reference to bz15945.

Fixed in r420777. Checking useRCPatrol() isn't enough, though, because new pages patrolling can be enabled independently. list=recentchanges now requires at least one of useRCPatrol() and useNPPatrol() to return true for obtaining patrol data.

(In reply to comment #1)

Fixed in r420777

Obviously, that should be r42077.