Page MenuHomePhabricator
Create Task
Maniphest T18421

list=logevents leuser= and list=usercontribs ucuser= parameters inconsistent
Closed, ResolvedPublic
Actions

Description

Author: herd

Description:
First: leuser does not allow underscores in place of spaces, but ucuser does, can they be made consistent? Preferred is to have _ always an alias for %20.
Compare:
http://test.wikipedia.org/w/api.php?action=query&list=usercontribs|logevents&lelimit=1&uclimit=1&ucprop=timestamp&leprop=timestamp|user&ucuser=Tim_Starling&leuser=Tim_Starling
http://test.wikipedia.org/w/api.php?action=query&list=usercontribs|logevents&lelimit=1&uclimit=1&ucprop=timestamp&leprop=timestamp|user&ucuser=Tim_Starling&leuser=Tim%20Starling

Second: leuser errors out if the user doesn't exist, but ucuser simply returns an empty contributions list. I am not sure which is ideal.
Compare:
http://test.wikipedia.org/w/api.php?action=query&list=usercontribs&uclimit=1&ucprop=timestamp&ucuser=NOSUCHUSER
http://test.wikipedia.org/w/api.php?action=query&list=logevents&lelimit=1&leprop=timestamp|user&leuser=NOSUCHUSER

Version: 1.14.x
Severity: enhancement

Details

Reference
bz16421

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:26 PM
• bzimport added a project: MediaWiki-Action-API.
• bzimport set Reference to bz16421.
• bzimport created this task.Nov 22 2008, 11:18 AM
Catrope added a comment.Nov 22 2008, 3:47 PM

(In reply to comment #0)

First: leuser does not allow underscores in place of spaces, but ucuser does,
can they be made consistent? Preferred is to have _ always an alias for %20.

Fixed in r43864.

Second: leuser errors out if the user doesn't exist, but ucuser simply returns
an empty contributions list. I am not sure which is ideal.

That's because the revision table (which usercontribs uses) stores the user ID and the user name (0 and the IP respectively for anons), while the logging table (which logevents uses) only stores the user ID. That means anons can't have log entries (bug 3732) and that you can't search the logging table for users that don't exist, because you need to look up their user ID first.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL