Page MenuHomePhabricator

Tidy causes corruption inside <gallery>
Closed, ResolvedPublic

Description

Author: avarab

Description:
Using the tidy configuration here (also used on Wikimedia websites):
http://cvs.sourceforge.net/viewcvs.py/wikipedia/extensions/tidy/tidy.conf?rev=1.2&view=markup
tidy will corrupt gallery captions.


Version: unspecified
Severity: major
URL: http://en.wikipedia.org/wiki/User:%C6var_Arnfj%F6r%F0_Bjarmason/gallery

Details

Reference
bz1765

Event Timeline

bzimport raised the priority of this task from to High.Nov 21 2014, 8:17 PM
bzimport added a project: MediaWiki-Parser.
bzimport set Reference to bz1765.
bzimport added a subscriber: Unknown Object (MLST).

avarab wrote:

This was an upstream issue as suspected, the patch needed to work around this
changed one line of code:

  • $sk->makeKnownLinkObj( $nt, $thumb->toHtml() ) . '</div><div

class="gallerytext">' .
+ $sk->makeKnownLinkObj( $nt, $thumb->toHtml() ) . '</div><div
class="gallerytext">' . "\n" .

See: http://mail.wikipedia.org/pipermail/mediawiki-cvs/2005-March/007241.html