Page MenuHomePhabricator

no edit toolbar
Closed, InvalidPublic

Description

Author: eric.gerbier

Description:
I found some problems with directories in the code :

the generated html code, contains a reference to
"/mediawiki/stylesheets/common/wikibits.js"
but the wikibits.js file is on /mediawiki/stylesheets/ directory

and I patch the includes/EditPage.php with :

850c850

< $image=$wgStylePath.'/common/images/'.$tool['image'];

$image=$wgStylePath.'/images/'.$tool['image'];

(the common/images does not exists)


Version: 1.4.x
Severity: normal
OS: Linux
Platform: PC

Details

Reference
bz1797

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 8:19 PM
bzimport set Reference to bz1797.
bzimport added a subscriber: Unknown Object (MLST).

avarab wrote:

wikibits.js is in /skins/common/, and applying your patch breaks 1.4 and HEAD,
you probably meant to submit this under some other branch, 1.3 perhaps?

If you've upgraded from 1.3 and kept your old LocalSettings.php, you should be sure to
update $wgStylePath to point to 'skins' instead of 1.3's old 'stylesheets' directory.

eric.gerbier wrote:

you're right !

I have read the UPDATE file, but I saw "you may need to change the style paths"
( not "you must change" ) so I did not modify the LocalSetting file.

thanks for this quick answer !