Page MenuHomePhabricator

Password failure after upgrade to MW 1.13 or 1.14
Closed, ResolvedPublic

Description

Submitting this here before I forget it.

http://permalink.gmane.org/gmane.org.wikimedia.mediawiki/31026

Users with $wgPasswordSalt=false before 1.13 will have their wiki destroyed by upgrade to 1.13 or 1.14, by re-running the web installer. The web installer has a default LocalSettings.php and so $wgPasswordSalt will not be right in updaters.inc update_password_format(). My fault, r35923. I probably assumed that nobody actually used $wgPasswordSalt, but of course it was documented in various places as a trial-and-error fix for miscellaneous upgrade problems.

Removing update_password_format() is probably the best thing to do, it was never run on Wikimedia and is unnecessary since b/c code exists. Needs 1.15 release.

Repair of a broken wiki is possible as in the mailing list post:

UPDATE user SET user_password =
CONCAT(':A:', SUBSTRING_INDEX(user_password,':',-1))
WHERE user_password LIKE ':B:%';

Don't try this without backing up your user table first.


Version: 1.14.x
Severity: major

Details

Reference
bz18846

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:41 PM
bzimport set Reference to bz18846.

Fixed in r51587/r51640 for release in 1.15.0.