Page MenuHomePhabricator

Media: links don't work; use http-noparse protocol
Closed, ResolvedPublic

Description

Author: dbenbenn

Description:
Links such as [[Media:Wiki.png]] no longer work in 1.6alpha. The
produced link is

http-noparse://upload.wikimedia.org/wikipedia/en/b/bc/Wiki.png

Every browser I've tried (Konqueror and Firefox) complains that this is
an unknown protocol.


Version: 1.6.x
Severity: critical

Details

Reference
bz3210

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 8:44 PM
bzimport set Reference to bz3210.

wiki.bugzilla wrote:

See http://en.wikipedia.org/wiki/Bach for example, many links in the main namespace are broken.

wiki.bugzilla wrote:

... forgot to point at the exact section where you can try all the broken media links: http://en.wikipedia.org/wiki/Bach#Media

Seems to affect all media: links when $wgUploadPath is non-local.

Bug was introduced within last couple of days on REL1_5 and HEAD.

Created attachment 821
Fix; checked in on Linker.php revision 1.48

Fixed on REL1_5 and HEAD. Someone changed how noparse links work without
updating all uses of it.

http://cvs.defau.lt/cvsweb.cgi/phase3/includes/Linker.php.diff?r1=1.47&r2=1.48

Attached:

rowan.collins wrote:

(In reply to comment #5)

Fixed on REL1_5 and HEAD. Someone changed how noparse links work without
updating all uses of it.

Sorry, my bad (fixing bug 3090) - didn't think to "grep -r" so only changed one
file :/
Should probably turn it into a pair of functions somewhere, to avoid such
problems (presumably there's a potential for the media: link to begin https://
not http:// and therefore break for the same reason as bug 3090...)