Page MenuHomePhabricator

VisualEditor: Invalid titles for link target are not detected by link editor (e.g. "Foo{}bar" is allowed)
Closed, ResolvedPublic

Description

Especially those break wikitext.


Version: unspecified
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=51090

Details

Reference
bz33094

Event Timeline

bzimport raised the priority of this task from to High.Nov 21 2014, 11:59 PM
bzimport set Reference to bz33094.

From
https://www.mediawiki.org/w/index.php?title=Visual_editor/Feedback&oldid=552919#Links_to_invalid_titles


The editor should not allow [//www.mediawiki.org/w/index.php?title=VisualEditor%3ATest&diff=552858&oldid=552851 links to invalid titles].

Not sure if new inspector blocks this?

Mass-moving items into VisualEditor product

Mass-move out of "General" to init.

Looks like a job for mw.Title in core.

It needs better validation. If static validation is not 100% waterproof we could built in a "extra sure" mode in mw.Title that makes an API request.

Fixed in https://gerrit.wikimedia.org/r/23373 similarly to the way wikiEditor checks for invalid page titles

Would be better handled in mw.Title.

Change 77099 had a related patch set uploaded by Esanders:
Prevent the creation of invalid MWInternalLinks

https://gerrit.wikimedia.org/r/77099

Change 77099 merged by jenkins-bot:
Prevent the creation of invalid MWInternalLinks

https://gerrit.wikimedia.org/r/77099

Fixed again. Sorry, everyone. Will be deployed to MW.org tomorrow, and we'll get it deployed more widely after testing.