Page MenuHomePhabricator

Enable $wgShowUpdatedMarker on the English Wikipedia
Closed, ResolvedPublic

Description

Per RFC held on [[Wikipedia:Village pump (proposals)#Enable "Show changes since last visit" on watchlist]], I would like to request that the $wgShowUpdatedMarker option be set to "true" for the English Wikipedia.


Version: unspecified
Severity: enhancement

Details

Reference
bz33123

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:02 AM
bzimport set Reference to bz33123.
bzimport added a subscriber: Unknown Object (MLST).

This sounds familiar (ENotif?), and I'm not sure it's so straight forward...

happy.melon.wiki wrote:

(In reply to comment #1)

This sounds familiar (ENotif?), and I'm not sure it's so straight forward...

IIRC the main issues are a) caching, and b) not being attacked by an angry Domas for causing a db write on every pageview...

If there are concerns about performance, back them up with data please. There are plenty of projects running on the same cluster with the option enabled, so I really see no reason to exclude the English Wikipedia.

(In reply to comment #3)

If there are concerns about performance, back them up with data please. There
are plenty of projects running on the same cluster with the option enabled, so
I really see no reason to exclude the English Wikipedia.

Most (if any) of those are the same as DB wise as en.wikipedia

(In reply to comment #4)

(In reply to comment #3)

If there are concerns about performance, back them up with data please. There
are plenty of projects running on the same cluster with the option enabled, so
I really see no reason to exclude the English Wikipedia.

Most (if any) of those are the same as DB wise as en.wikipedia

  • Most (if any) of those are the same size DB wise as en.wikipedia

happy.melon.wiki wrote:

(In reply to comment #5)

Most (if any) of those are the same size DB wise as en.wikipedia

*Few* (if any)...??

(In reply to comment #3)

If there are concerns about performance, back them up with data please. There
are plenty of projects running on the same cluster with the option enabled, so
I really see no reason to exclude the English Wikipedia.

I'm not in any place to say whether there *are* crippling performance concerns; only that that is, IIRC, a concern that has been raised about this feature in the past.

$wgShowUpdatedMarker is enabled on WMF wikis which have $wgEnotifWatchlist enabled (or rather, is disabled on wikis which don'w). The vast majority of wikis which have it enabled are fishbowls; public wikis basically come down to:

'arwikiversity' => true,
'brwikimedia' => true,
'commonswiki' => true,
'cswiki' => true,
'cswikinews' => true,
'cswikiversity' => true,
'enwikisource' => true,
'frrwiki' => true,
'hiwiki' => true,
'nlwiki' => true,
'mediawikiwiki' => true,
'metawiki' => true,
'nowikinews' => true,
'ptwiki' => true,
'sourceswiki' => true,

None of those are anywhere near the top of the traffic list (note that's fr*r*wiki, not frwiki).

$wgShowUpdatedMarker is enabled on WMF wikis which have
$wgEnotifWatchlistenabled...

I don't see how the two are related. $wgShowUpdatedMarker requires $wgEmailAuthentication to be set, but none of the $wgEnotifXXX options. We're not requesting email notification, we're requesting Watchlist notification.

happy.melon.wiki wrote:

(In reply to comment #7)

$wgShowUpdatedMarker is enabled on WMF wikis which have
$wgEnotifWatchlistenabled...

I don't see how the two are related.

CommonSettings.php:
// Enable enotif for user talk if it's on for watchlist.
if ( $wgEnotifWatchlist ) {

	  $wgEnotifUserTalk = true;

} else {

	  $wgShowUpdatedMarker = false; // not working right ?

	  // Trial by Roan, Mark B and Mark H, Nov 8 2011
	  // Set $wgEnotifUserTalk to true everywhere, but keep $wgShowUpdatedMarker disabled where it was disabled previously
	  $wgEnotifUserTalk = true;

}

Again, I'm not saying that things *have* to be this way; I'm saying how they currently *are*.