Page MenuHomePhabricator

Separate user preference to allow watching uploaded images
Closed, DeclinedPublic

Description

Author: dunc_harris

Description:
As per [[bug:2570]] http://bugzilla.wikimedia.org/show_bug.cgi?id=2570 new uploaded
files can be added to one's watchlist. This was mentioned in that bug report but is a
slightly separate issue (and anyway, that one is closed). Can we have something in the
user preferences to be able to set this as default on or off?


Version: unspecified
Severity: enhancement

Details

Reference
bz3509

Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 21 2014, 8:50 PM
bzimport set Reference to bz3509.
bzimport added a subscriber: Unknown Object (MLST).

This is already there; in English the pref is labeled something like "Watch
pages you edit by default". (It's the same for images and pages, not a separate
pref.)

dunc_harris wrote:

Ah, what I meant was that I don't want to watch all pages I edit, but I do want to watch all images I
upload. So I think that there should be separate prefs.

dunc_harris wrote:

Specifically,

At present, the "Watch this page" tickbox in [[special:upload]] is ticked if in
[[special:preferences]], either "Add pages I edit to my watchlist" andor "Add
pages I create to my watchlist" are checked. It doesn't matter if "Add pages I
delete to my watchlist" is checked. This is a bit messy. I don't know what
will happen with http://bugzilla.wikipedia.org/show_bug.cgi?id=8461 but I don't
think it will affect it.

It makes sense for there to be five separate options one each for
create/edit/move/upload/delete. There therefore needs to be a separate tickbox
option for this in [[special:preferences#prefsection-7]], "Add files I upload to
my watchlist", to have the box checked/unchecked by default.

Hope that is a better explanation.

Uploading should be counted as a special-case of edit operations for UI purposes.

dunc_harris wrote:

Then why is there separate options for (a) delete, (b) move? Why are they not
"a special-case of edit operations for UI purposes"?

Then why is upload turned on if either (a) edit or (b) create are checked?

What happens if I want to add images I upload to my watchlist, but not pages I
edit or create?

The present situation makes no sense.

It would make a lot more sense if this was split out into a separate option.

Yes, those should all be re-merged.

dunc_harris wrote:

In which case that would be a separate "bug", and would reduce usability, not
increase it.

I want to watch all files I upload, but not all that I create or edit. I cannot
do that.

You don't have to fix a bug if you don't want it fixed, but with all due
respect, you must come up with a good reason for closing instead of leaving it
open for someone else to fix.

That there are three votes for this, is an indication that others agree with me.

I believe I've already indicated that it seems unnecessary, and so is not likely
to be added. Leaving the bug open would be counterproductive as it might lead
someone to believe that a patch would be accepted.

I should point out that if you simply must have it yourself, this should be
quite straightforward to do in your user-customized JavaScript.

ayg wrote:

(In reply to comment #7)

You don't have to fix a bug if you don't want it fixed, but with all due
respect, you must come up with a good reason for closing instead of leaving it
open for someone else to fix.

When the lead developer of a project says WONTFIX, that means "fixes are not
going to be added to the repository", not "I'm not personally going to fix it".

feloniousmonk.wikipedia wrote:

Watching uploaded images as a user preference seems to be a common sense bit of
useful functionality we should add. What's the big deal?

STOP WITH THIS BUG PLEASE.

We said NO.

dunc_harris wrote:

Is this the royal we?

You should only close it as WONTFIX if there's some kind of impossible technical
mountain to climb. And I can't see that there's one here.

You don't have to fix it, that's why it's an enhancement.

I've tried to be polite about it, but maybe Brion should take a leaf out of
Jimbo's book in his attempt to become a benevolent dictator.

Duncan, this (MediaWiki) is a software development project, not a community.

WONTFIX indicates that the request will not be fulfilled. There does not have to
be an "impossible technical mountain to climb". There are millions of things
that technically *could* be added but will not be, because they are unnecessary
or perhaps undesirable.

You do not have a special right to have the request kept open. Keeping the
request open accomplishes nothing, and would be misleading when it has already
been rejected.

Simply reopening it over and over does not accomplish anything other than making
you look like an unpleasant person and a bad sport, which makes me less inclined
to pay attention to any new arguments you may actually have in favor of the
requested change.

I can assure you that continuing in this manner will not get your request
fulfilled; if anything it will guarantee that it will not be fulfilled because
now the idea is associated with "angry emotional guy on internet".

Let's try to act like adults instead.

Duncan, if you have new, reasoned arguments for making this change please feel
free to post them. Same goes for anyone else.

But please don't reopen the bug unless there is some *dire* reason for it (which
I really can't imagine happening). If I'm swayed by your arguments, then the bug
will get reopened.

(In reply to comment #10)

Watching uploaded images as a user preference seems to be a common sense bit of
useful functionality we should add. What's the big deal?

We already have this feature; when set to watch on new page creation, uploading
a new file (which is a special type of page creation) will automatically check
the box. I believe this also works when set for all edits.

It's also possible to customize it through JavaScript, eg to check the watch box
only for file uploads but not for other kinds of pages you create.

User preferences always complicate things; surprise interactions, additional
testing burden, behavior differences between different accounts when trying to
explain things to fellow users, etc. Thus new options are (or should be) held to
a high standard of "is this actually needed?"

In my opinion this isn't really needed separately, and if something like it
really is needed then just adding similar options willy-nilly is probably not a
clean way to do it.