Page MenuHomePhabricator

Phantom 'You have new messages' notification with enotif
Closed, ResolvedPublic

Description

Author: muke

Description:
Since upgrading to 1.5.0 (and still now at 1.5.1) a
user has experienced the "You have new messages"
notification at all times, even though he has
visited his talk page, and it has not been edited.

On a separate wiki I have experienced the same
problem, creating a new user account and editing my
own talk page: I get "You have new messages" on
every page except the talk page itself; even upon
updating / editing the talk page, it doesn't go
away.


Version: 1.5.x
Severity: normal

Details

Reference
bz3805

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 8:53 PM
bzimport set Reference to bz3805.
bzimport added a subscriber: Unknown Object (MLST).

robchur wrote:

Is this a caching problem? Try a refresh or a hard-refresh from within your
browser. Also, check the talk page history to make sure it *hasn't* been edited.

This is an odd behavior that was present in 1.5rcX (and/or 1.5betaX) too. There
is a page on meta describing how to get rid of this, but in my case I've tried
everything, except messing with DB. Some other users have reported the same thing.

muke wrote:

Yes, it's no caching problem (at least, no browser-caching
problem) as it still shows up even visiting new pages, and the
talk page hasn't been edited.

Filip: Could you link to that meta page? I'm not finding it.

Muke: I can't seem to find it either. Maybe it wasn't meta. Possibly another bug...

bena wrote:

I have had this problem on 1.5b4 and 1.5.1. In our case it happens every time a user talk page is modified.
The only way we can clear the "you have new messages" notification is to watch-cycle the talk page.

As other people have reported, the "you have new messages" notification appears after the talk page has been
visited even on new pages that I haven't visited before, so it's clearly not a browser caching issue. (And
hard-refreshing the browser doesn't help.)

MediaWiki: 1.5.1
PHP: 4.3.8 (apache2handler)
MySQL: 4.0.20a-debug

The revisited Enotif patch

http://bugzilla.wikimedia.org/show_bug.cgi?id=2014

and also the current version of EnotifWiki based on MediaWiki1.5rc4 see

http://developer.berlios.de/projects/enotifwiki/ and http://www.enotifwiki.org

do not show this problem. Unfortunately, currently I cannot supply a "diff"
patch for MW 1.5.1

jbutler wrote:

I can confirm that this bug persists in

MediaWiki: 1.5.2
PHP: 4.3.2 (apache2filter)
MySQL: 3.23.58
Redhat Linux

stux wrote:

We have noticed at the HRWiki that the bug seems to affect only those usernames
that contain spaces on them.

gangleri wrote:

(In reply to comment #8)

... seems to affect only those usernames that contain spaces on them.

This is the case refered in
Bug 4031: not able to clear "You have new messages" when making a redirect from
your talk page to another talk page

best regards reinhardt [[user:gangleri]]

gangleri wrote:

*** Bug 4031 has been marked as a duplicate of this bug. ***

mediawikibugs wrote:

(In reply to comment #8)

We have noticed at the HRWiki

Details for our setup:

  • MediaWiki: 1.5.2
  • PHP: 4.3.11 (apache)
  • MySQL: 4.0.25-standard
  • Linux 2.4.21-4.ELsmp

bena wrote:

We are using "Firstname Lastname" for our usernames, so they all contain the
space character. WikiSysop is the only user on our system without a space in
their name. When I logged in as WikiSysop and viewed its talk page the
banner message was cleared. So I can confirm that on our installation having
a space in the username appears to be a precondition for the bug to occur.

I have tried again unsuccessfully to reproduce the bug at Wikipedia.
Discussion on Mediawiki-l suggested that the special caching software used
at Wikimedia sites might hide the bug.

My setup is described above, running on Windows XP Professional.

bena wrote:

I have tried ticking the "Disable page caching" option under user preferences, but this doesn't fix the problem.

robchur wrote:

(In reply to comment #12)

I have tried again unsuccessfully to reproduce the bug at Wikipedia.
Discussion on Mediawiki-l suggested that the special caching software used
at Wikimedia sites might hide the bug.

Unless the bug or whatever is fixed in 1.6-dev, in which case it won't affect
Wikipedia, nor any other Wikimedia web site, since we live on the edge with
those. ;-)

(In reply to comment #0)

user has experienced the "You have new messages"
notification at all times, even though he has
visited his talk page, and it has not been edited....
updating / editing the talk page, it doesn't go
away.

Perhaps you can contact the user and ask to click once onto the "Mark all pages
visited" link on their watchlist (to see if the problem is then solved).

Already some week ago, I recommended also to apply my patch as mentioned in
comment 6 to this bugzilla http://bugzilla.wikimedia.org/show_bug.cgi?id=3805#c6 .

gangleri wrote:

(In reply to comment #14)

(In reply to comment #12)

I have tried again unsuccessfully to reproduce the bug at Wikipedia.

Rob please tray to reproduce the bug at http://test.leuksman.com/ creating a new
account containing spaces. Please let us know the results. Thanks in advance!

gangleri wrote:

Ups wrong link!

(In reply to comment #14)

I have tried again unsuccessfully to reproduce the bug at Wikipedia.

Rob please tray to reproduce the bug at http://test.leuksman.com/view/Main_Page
creating a new
account containing spaces. Please let us know the results. Thanks in advance!

gangleri wrote:

changing to WORKSFORME
I tested this extensivly with various usernames ( see
http://test.leuksman.com/view/Category:Bugzilla/BiDi )containing a space at
http://test.leuksman.com/ .

The problem disapeared. Thanks Brion!

mediawikibugs wrote:

(In reply to comment #18)

changing to WORKSFORME
I tested this extensivly with various usernames ( see
http://test.leuksman.com/view/Category:Bugzilla/BiDi )containing a space at
http://test.leuksman.com/ .

The problem disapeared. Thanks Brion!

But this bug relates to behavior in version 1.5. http://test.leuksman.com runs
version 1.6devel.

I might be wrong in doing this, and please correct me if I'm wrong, but I'm
removing the WORKSFORME tag and reopening, as it does not work on version 1.5.

bena wrote:

I agree it appears to be fixed at leuksman.com. What version is that site at? Can
we assume it will also be fixed in the next stable release?

Maybe it's already fixed in 1.5.3. Has anyone upgraded to 1.5.3 and checked this
defect?

Sorry about the barrage of questions!

dotcom wrote:

The bug persists in 1.5.3. Our configuration:

MediaWiki: 1.5.3
PHP: 4.3.11 (apache)
MySQL: 4.0.25-standard

This is a bug in the old enotif code, which has since been replaced on the development branch.

Created attachment 1167
Quick fix for REL1_5

Fixed bad comparison in UserTalkUpdate.php

Attached:

dotcom wrote:

I applied the above patch, and it resolved the problem at our wiki. Thanks, Brion!

Must have forgot to mark this FIXED.

bena wrote:

Thanks heaps for the patch Brion, it works perfectly for me too.

bena wrote:

I can confirm that this is in 1.5.4. Thanks!