Page MenuHomePhabricator

Style dir fixed in Skin.php
Closed, ResolvedPublic

Description

Author: webboy

Description:
The Style-directory is fixed in includes/User.php as $IP.'/skins'. This should
be $wgStyleDirectory.


Version: 1.6.x
Severity: normal
URL: http://wikipedia.sourceforge.net/doc//__filesource/fsource_MediaWiki__includesUser.php.html

Details

Reference
bz4033

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 8:57 PM
bzimport set Reference to bz4033.
bzimport added a subscriber: Unknown Object (MLST).

webboy wrote:

Same in includes/Skin.php:

$skinDir = dir($IP.'/skins');
should be
$skinDir = dir($wgStyleDirectory);

robchur wrote:

Neither $wgStyleDirectory nor any other of those types of variables have a value
at the time that $IP is set. Closing not valid, as there's a reason $IP is like
it is.

webboy wrote:

$IP is set in LocalSettings.php, $wgStyleDirectory is set in LocalSettings.php
AND DefaultSettings.php, what’s the differance?

Also the chances in Skin.php and User.php work for me.
(Don't forget to change

global $IP, $wgRequest;

to

global $wgStyleDirectory, $wgRequest;

in function &getSkin())

robchur wrote:

They're set much later. $IP is a special case and is done like that *for a reason.*

webboy wrote:

I have changed and tested it on my testwiki and I works whitout warnings. So
it's possible to change!

(PS Use RESOLVE WONTFIX next time.)

webboy wrote:

Fixed User.php and Skin.php (MediaWiki 1.5.2)

See attachment for fixed User.php and Skin.php (For MediaWiki 1.5.2)

attachment Fixed_User-php_and_Skin-php.rar ignored as obsolete

webboy wrote:

User.php is fixed in version 1.198, Mon Dec 19 23:36:43 2005 UTC

webboy wrote:

Making a patch for Skin.php...

webboy wrote:

Patch for Skin.php

Patch for Skin.php - tested on own wiki

Attached:

robchur wrote:

*** Bug 5960 has been marked as a duplicate of this bug. ***

robchur wrote:

Fixed in SVN trunk, r14449.