Page MenuHomePhabricator

Toolbar should be enabled for Safari
Closed, ResolvedPublic

Description

Author: z9z8z-wps

Description:
The toolbar (above the edit window) was at some point disabled for the Safari browser by a change to skins/common/wikibits.js (probably by the
change from Revision 1.14 to 1.15).

Current Safari versions handle the toolbar functions pretty well so it should be re-enabled for Safari.

Proposed fix:

The function addButton in wikibits.js contains:

if (!document.selection && !is_gecko) {

return false;

}

The first of these lines should be replaced by

if (!is_safari && !is_gecko) {

(Since that code is executed when a page loads, document.selection might always be undefined)


Version: 1.6.x
Severity: normal

Details

Reference
bz4663

Related Objects

StatusSubtypeAssignedTask
ResolvedNone
ResolvedNone

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 9:03 PM
bzimport added a project: MediaWiki-Parser.
bzimport set Reference to bz4663.
bzimport added a subscriber: Unknown Object (MLST).
  • Bug 4921 has been marked as a duplicate of this bug. ***
  • Bug 5324 has been marked as a duplicate of this bug. ***

pete wrote:

Found a wiki that I could edit with buttons, and did a search for inurl:special:version for more data points: at time of writing the buttons are visible in wikis that use MediaWikis pre
1.5.6, 1.5rc3 and rc4, but not wikis using MediaWiki 1.6alpha. Didn't find any 1.5.7s I could log into though.

  • Bug 6210 has been marked as a duplicate of this bug. ***