Page MenuHomePhabricator

VisualEditor: "Review your changes" - cancel-arrow needs a tooltip; possibly replace with an "X"?
Closed, ResolvedPublic

Description

Arrow shown in top-right, under search bar

The Up-Arrow icon, at the top-right of the "Review your changes" dialog (which cancels the review window) needs a tooltip.

I suggest: "Cancel review, go back to current edit" or similar.


Version: unspecified
Severity: enhancement

Attached:

Review-cancel-up-arrow-needs-tooltip.png (249×406 px, 9 KB)

Details

Reference
bz49147

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:48 AM
bzimport set Reference to bz49147.

There's an Identical problem with the "Report a problem" dialog, in two places.

  1. The left-arrow at the left-hand-side needs a tooltip. "Cancel report, go back to Review" or similar.
  1. The up-arrow at the top-right needs a different tooltip. "Cancel report, go back to current edit" or similar.

(I'm not sure if you'd prefer this in the same bug, or split into 2 bugs, or even 3 bugs. Please let me know.)

Someone else commented on this today, and suggested that an [X] might be a better icon than a < or ^.

See http://en.wikipedia.org/wiki/Wikipedia:VisualEditor/Feedback#Link_pop-up for further discussion.

  • Bug 49983 has been marked as a duplicate of this bug. ***

Also needed in "Save your changes" dialog for up and left arrows.

Argh, yes, Kaldari got his comment in before mine. :-)

santosh.cool.reddy wrote:

I see that this bug has been cleared. Please check the bug and close this bug.

santosh reddy: I have no idea what you meant by "cleared". This bug report is still open and there is no patch mentioned. In case you meant that the bug is fixed for you, please provide a clear link where you see it fixed. Thanks.

santosh.cool.reddy wrote:

"Review your changes" - cancel-arrow needs a tooltip; possibly replace with an "X"?

Look at the attached image,looks like this bug has been already solved. Arrow is replaced by an 'X'.

Attached:

Screenshot_from_2014-03-15_21:59:41.png (941×1 px, 56 KB)

All left-arrows (except for the link-dialog?) appear to have been replaced with "X", and all "X"s (plus the link-dialog arrow) have tooltips.

I think this can be closed-as-fixed, but I will leave it up to the product team in case I missed something that they're tracking with this.

Yes, this was fixed ages ago. Apologies for not noting and closing then – thanks for the reminder!