The logical expression in MediaWiki is incorrect, you need to add a pair of
parentheses marked as *(* and *)*

MediaWiki ( 2 parentheses missing)
http://cvs.sourceforge.net/viewcvs.py/wikipedia/phase3/includes/UserMailer.php?annotate=1.38
:

if *(* ( ( $enotifwatchlistpage &&
$watchingUser->getOption('enotifwatchlistpages') ) ||

	  	  	  ( $enotifusertalkpage &&

$watchingUser->getOption('enotifusertalkpages') ) *)*

	  	  	  && (!$minorEdit || ($wgEnotifMinorEdits &&

$watchingUser->getOption('enotifminoredits') ) )

	  	  	  && ($watchingUser->isEmailConfirmed() ) ) {

See also EnotifWiki
http://cvs.berlios.de/cgi-bin/viewcvs.cgi/enotifwiki/enotifwiki/includes/UserMailer.php?annotate=1.10
for the correct part.

a regular patch will not follow, because this is a trivial change.

Please test 1.6 from CVS HEAD; 1.5 is old and lots of email notification bits are broken in it.

(In reply to comment #3)

Please test 1.6 from CVS HEAD; 1.5 is old and lots of email notification bits

are broken in it.

Brion, the small amendment is also needed in your MediaWiki HEAD, where I took
the code sniplet from.

sacolcor wrote:

Pinging the radar on this; it's a trivial fix for an obvious bug, with a patch provided and review requested, and no action on it for over a year.

robchur wrote:

Need an actual patch file; patches in comments of this nature are a bit awkward to review.

sacolcor wrote:

Patch as described in prior comments

Attached:

Applied w/ formatting adjustments in r25974, but I can't actually reproduce the bug.

I seem to get the expected behavior both with and without the patch.