Page MenuHomePhabricator

Bad title error condition produces some silly links
Closed, ResolvedPublic

Description

If you try to go to a bad title, the error message shows on a pseudo-page titled "Bad title". This includes showing talk page, edit,
watch and undelete links for "[[Bad title]]"!

Perhaps bad title & similar errors need to work on a hidden [[Special:Error]], like the search now does.


Version: 1.4.x
Severity: minor
URL: http://en.wikipedia.org/wiki/%3Cbad%3E

Details

Reference
bz502

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 6:57 PM
bzimport set Reference to bz502.
bzimport added a subscriber: Unknown Object (MLST).

Fixed in cvs, error pages stop showing the quickbar.

  • Bug 852 has been marked as a duplicate of this bug. ***

(In reply to comment #1)

Fixed in cvs, error pages stop showing the quickbar.

http://cvs.sourceforge.net/viewcvs.py/wikipedia/phase3/includes/SkinPHPTal.php?r1=1.109&r2=1.110

This change caused a very ugly regression: the tabs are all missing in diff page views except a bogus
"special page" tab (bug 987). The 'quickbar' is the *sidebar*; under some of the older skins the diff view
turned off the sidebar in order to maximize the horizontal space available to show side-by-side diffs.
MonoBook isn't really set up to make disabling the sidebar possible, so it was just ignored.

Quickbar suppression doesn't seem to be the right trigger here.

In addition to breaking diff pages in MonoBook, the co-opting of quickbar
suppression also makes error pages look really weird in the Classic skin.
I've removed the broken fix.

  • Bug 1341 has been marked as a duplicate of this bug. ***
  • Bug 3970 has been marked as a duplicate of this bug. ***

gangleri wrote:

Another error condition is handeled at

Bug 4638: Error condition generates wrong tabs links pointing to {{PAGENAME}} in
the main namespace and not to {{FULLPAGENAME}}

best regards reinhardt [[user:gangleri]]

supersammyfluff wrote:

Couldn't this problem be fixed by changing [[MediaWiki:Badtitle]]? I'm not sure
what it would break, but it seems to work at a wiki I tested it on. (See
http://fanstuff.hrwiki.org/index.php/MediaWiki:Badtitle and
http://fanstuff.hrwiki.org/index.php/|)

Patch to set $wgTitle to "Special:Badtitle" instead of "Bad title" when a bad title is encountered

This simple change seems to fix it. I've tested it locally and found no
breakage, though I'd naturally welcome additional testing.

There is, of course, no Special:Badtitle; this doesn't really matter, the point
is just to set $wgTitle to any title in NS_SPECIAL. In fact, it's probably
better for it to be a nonexistent page, just in case any skin tries to link
back to it.

Non-monobook skins, in fact, apparently do just that, through a "Printable
version" link; I'm not sure if that should be considered a bug in those skins.
Monobook doesn't provide such a link for special pages at all, although it does
provide a "Special page" tab linking back to the original bad title (*not* to
Special:Badtitle). In either case, any user that happens to click such a link
is merely confronted with a second, rather self-explanatory error page.

Attached: