Page MenuHomePhabricator

Tool-tips in editing toolbar show JavaScript under Opera
Closed, ResolvedPublic

Description

Author: ben

Description:
On every edit page of WikiMedia software, the icons (Bold, Internal Link etc.) popup
text with code (Title: and Address:javascript:inserttags(blahblahblah)) but not any
usefull instruction to the user like they should. This is a very visible page and to the
first time user this is cryptic and meaningless. Heck, to a seasoned user this is still
cryptic and not usefull.

This is as seen in Opera.


Version: unspecified
Severity: normal
OS: Windows XP
Platform: PC

Details

Reference
bz5235

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 9:07 PM
bzimport set Reference to bz5235.
bzimport added a subscriber: Unknown Object (MLST).

robchur wrote:

Step one. Upgrade to MediaWiki 1.5.7. MediaWiki 1.5rc4 is a release candidate
and could well have been broken.

robchur wrote:

(Sigh, removing bogus URL change)

Wiki.Melancholie wrote:

Why "bogus"? I changed the URL about the same time you changed the Summary. For
the old summary it would have been a help for you to easily get the point of
this bug. But now a URL with &action=edit in it would be more appropriate,
wouldn't it?

Provide very specific information if still happening.

Wiki.Melancholie wrote:

(In reply to comment #2, #3)

Furthermore the initial URL has been http://wikipedia.org/, so I
thought (not seeing v1.5rc4) "every edit" would also affect Meta;
and so the URL would have lead you to a page where you just would
have had to click "edit"; so "[[Much Ado About Nothing|Sigh No
More, Ladies...]]" ;-)

@Ben: Sorry for this. But in which wiki did you experience this
problem?

ben wrote:

Ok I inspected it a little more and it looks like this is an Opera issue,
independent of which release (http://en.wikipedia.org/w/index.php?
title=Theodore_Roosevelt&action=edit) shows it as well as my site
(http://captainwiki.com/index.php?title=Pain_de_Campagne_%
28Crusty_French_Bread%29&action=edit) on edit pages buttons.

In Internet Explorer the buttons just show the popup title (Bold Text)
which is clear enough. But in Opera a popup also shows the javascript
link, see (Title: Bold Text Address:javascript:inserTtags
('\'\'\,'\'\'\,'Bold Text');) This text is NOT being put into the textbox
but just showing up on the dragover popup.

I don't know if this can be changed, but when a first time user see's this
popup, it confuses them. And rightly so.

One suggestion is to depreciate the inserTtags() function and break it
into seperate functions that are actually descriptive for each of the
buttons. Either that or change the text that is sent to the inserTtags()
function to something a little more user friendly. As a programmer myself
I don't like the idea of changing functions just for an interface but...
I'm not sure of any other solution... and this would work.

Tested Opera 9 TP2 on Mac OS X.

Opera's tooltop shows two lines, like this:

Title: Bold text
Address: javascript:insertTags('\'\'\'','\'\'\'','Bold text');

This seems to be a special magic "feature" of Opera; most browsers just show the address
tucked away in the status bar, and don't slap you in the face with it on a tooltip!

It might be possible to "work around" it by using an empty address and moving the code to an
onclick handler. However this would hide the code in the status bar from everybody with
normal browsers, which power users might like to see. I'm inclined to leave it be unless
there's some overwhelming reason otherwise.

ben wrote:

Maybe it would be beneficial to just add an extra line in the Title so the Address
isn't as "overpowering". For Example:
Title: Bold text

Inserts ''' characters around selected text to make it bold.

Address: javascript:insertTags('\'\'\'','\'\'\'','Bold text');

What do you think?

I know us tech guys you may not think this is a big deal but I have explained this
toolbar to 3 people out of three with Opera.

ben wrote:

By the way in the above example I had space in front of before "Inserts" in the
second title line so it lined up with "Bold". It looked a lot clearer like this, But
the formatting was removed in the comment.