Page MenuHomePhabricator

VisualEditor: Firefox up-down cursoring around aliens is broken, takes user to end of page sometimes
Closed, ResolvedPublic

Description

When the first line of an article is a hatnote template that generates exactly 1 line of text in the visual editor, pressing down twice takes you to the end of the article. When the hatnote template generates more than one line then pressing down takes you to the end of the first line but no further.

I have been unable to reproduce this with templates other than hatnotes.

Steps to reproduce (short hatnote):

  1. Load a page with a short hatnote in VE, e.g. [[Laurence of Canterbury]]
  2. Press the down cursor twice

Expected behaviour: you end up on the third line of the page
Actual behaviour: you end up on the last line of the page

Steps to reproduce (long hatnote):

  1. Load a page with a long hatnote in VE, e.g. [[An American in Paris]]
  2. Press the down cursor three or more times.

Expected behaviour: you end up on the third or fourth etc. line of the page
Actual behaviour: you end up at the end of the first line of the hatnote.

Sandbox pages to test:
Long hatnote: https://en.wikipedia.org/w/index.php?title=User:Thryduulf/sandbox&oldid=566827194&veaction=edit
Short hatnote: https://en.wikipedia.org/w/index.php?title=User:Thryduulf/sandbox2&oldid=566827110&veaction=edit

This might be related to bug 51708


Version: unspecified
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=51708

Details

Reference
bz52445

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:46 AM
bzimport set Reference to bz52445.

I have been unable to reproduce this at all on all of the linked pages, with both Monobook and Vector on Chrome, Win7.

My testing was in Monobook in Firefox 22 on Linux.
The original reporter was using Monobook in Firefox 22 on Windows 7.
Rybec comments that they can reproduce it in some pages (e.g. my sandbox) but not others (e.g. [[Laurence of Canterbury]]) using Firefox ESR on Linux.

It's starting to look like it might be a Firefox-only bug.

Have tested this again, and I believe we have fixed this bug as reported, as part of the re-writing of how ContentEditable reacts to cursor events. However, I think I've found another bug semi-related, so will open that.