robchur wrote:

(In reply to comment #0)

• "$5" should be included in Messages.php, like in MessagesHe.php now - it is

Bug #5009, and I will fix it here.

If CVS were working, the fix for this oversight would have been checked in by
now; I came across it myself when working on something else last night.

• We should swap the patrolled ($4) and my edits ($5) locations, because "my

edits" ($5) is similar to "registered users" ($3).

Don't swap parameter order in interface messages unless there's a real good
reason, since it will break a hell of a lot of wikis.

rotemliss wrote:

(In reply to comment #1)

(In reply to comment #0)

• "$5" should be included in Messages.php, like in MessagesHe.php now - it is

Bug #5009, and I will fix it here.

If CVS were working, the fix for this oversight would have been checked in by
now; I came across it myself when working on something else last night.

Please don't, because then I will have to wait some hours, or one day, before I
will be able to create a proper patch here.

• We should swap the patrolled ($4) and my edits ($5) locations, because "my

edits" ($5) is similar to "registered users" ($3).

Don't swap parameter order in interface messages unless there's a real good
reason, since it will break a hell of a lot of wikis.

I think it won't, because we also replace the interface message names, so even
before MediaWiki default will be used to create it, it will be availlable.

robchur wrote:

(In reply to comment #2)

[sigh]

1. You won't be able to submit a patch against CVS HEAD while CVS is down

regardless. And I couldn't care less about a third party patch, I would have to
edit the message to add functionality anyway.

2. Missed the entire point of the statement.

rotemliss wrote:

(In reply to comment #3)

(In reply to comment #2)

1. You won't be able to submit a patch against CVS HEAD while CVS is down

regardless. And I couldn't care less about a third party patch, I would have to
edit the message to add functionality anyway.

I can log in to the CVS (cvs login - my CVSROOT is the MediaWiki CVS - works,
but I didn't check the diff). Maybe the CVS for anonymous users is not down.

As for the second statement - what do you mean? I will have to create a patch
with "diff" anyway.

2. Missed the entire point of the statement.

Do you mean I missed etc., or you missed etc.?

rotemliss wrote:

Patch

The patch does what I've suggested, and although I didn't use
rebuildMessages.php in my installed Wiki (which has installed with
"showhideminor"), it didn't break it, just left behind the useless page
"MediaWiki:Showhideminor".

The patch is for CVS MAIN (HEAD) only - I won't create a patch for REL1_5.
Please check it in soon.

As for the non-English and non-Hebrew projects, they will need update their
language file; nowadays, this message will be shown in English for them.

attachment bug.5409.v1.patch ignored as obsolete

rotemliss wrote:

When I will be able to use Subversion (when understanding the commands, etc.), I
will create a new patch - I see you've added a new option, of hiding the
anonymous edits, and by the way fixed Bug #5009.

rotemliss wrote:

Patch v2

Updated patch, due to recent updates and the switch to Subversion.

Attached:

robchur wrote:

The bug is fixed in SVN HEAD, but I took the opportunity to clean up that
segment of code. I didn't want to hack in more stuff, so I split up the message
and did it in a nice clean fashion.