Page MenuHomePhabricator

Should not be possible to send thanks for oversighted edits
Closed, ResolvedPublic

Description

The (thanks) link still appears next to an edit that has been oversighted or otherwise suppressed. Clicking the link gives the confirmation as normal and clicking OK appears to send the thanks as normal (I'm waiting for confirmation of whether the thanks is received - I don't have access to oversight to test on one of my own edits).

Suppression of an edit should also suppress the ability to thank someone for that edit.

I spotted this bug at https://en.wikipedia.org/w/index.php?title=Wikipedia:Arbitration/Requests/Case/Manning_naming_dispute/Workshop&action=history where the edits from 00:26 to 02:37 on 13 September have been removed.


Version: unspecified
Severity: normal

Details

Reference
bz54100

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:14 AM
bzimport added a project: Thanks.
bzimport set Reference to bz54100.

The user concerned has replied saying that they did receive the thanks:

"You did thank me, and it seemed to appear normally. The view edit link gave me this, which goes to the oversighted diff. [...] there did not seem to be anything overly broken about it."

The link given was https://en.wikipedia.org/w/index.php?title=Wikipedia:Arbitration/Requests/Case/Manning_naming_dispute/Workshop&oldid=572700018&diff=prev

Change 88223 had a related patch set uploaded by Legoktm:
Only show Thanks links for public revisions

https://gerrit.wikimedia.org/r/88223

Change 88223 merged by jenkins-bot:
Only allow Thanks for public revisions

https://gerrit.wikimedia.org/r/88223