Page MenuHomePhabricator

Set "autopatrol" by default to on, if the user is sysop (else it's not exist)
Closed, ResolvedPublic

Description

Author: rotemliss

Description:
The preference "autopatrol" should be default on if the user is a sysop, because
if we trust him to mark changes as patrolled, we can trust his edits.


Version: 1.9.x
Severity: minor

Details

Reference
bz5411

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 9:10 PM
bzimport set Reference to bz5411.
bzimport added a subscriber: Unknown Object (MLST).

robchur wrote:

In this case, it makes no sense for it to be a user preference option at all.

rotemliss wrote:

Rob removed the preference in r18435.

robchur wrote:

<accent style="very british">Oh, bugger!</accent> I knew I forgot to close
something else!

andreengels wrote:

On Dutch Wikipedia, the new "autopatrol" functionality is considered a bug,
rather than the resolution of a bug.

rotemliss wrote:

This new feature is not new - every user who can patrol could choose to do that
in his preferences, and anyway, it's not about this bug. Please open another one.

robchur wrote:

The problem is that I overlooked the issue where, e.g. on the Dutch Wikipedia,
all autoconfirmed users can patrol; there's a difference between assuming most
users can be trustworthy, and automatically assuming all are.

The best resolution for this, I think, would be to introduce a new user right,
that is; autopatrolling occurs if the user has "autopatrol" rights - and set
these to be the default for sysops only.

We can work on things like a proper patrollers group later, possibly if/when the
Patroller extension goes live.

robchur wrote:

Solution above adapted in r18496. If a user has the "autopatrol" permission,
then their edits are auto-marked as patrolled. Users without the "autopatrol"
permission now can't mark their own edits as patrolled.