Page MenuHomePhabricator

job-queue insert appears to fail for highly used templates
Closed, ResolvedPublic

Description

I just edited some highly used templates on Commons (among others, PD-old, used
about 30 thousand times, and PD-Art, used about 15 thousand times). When saving,
i got a "sorry we have a problem" error, but checking the template again showed
the edit went though. But looking at Special:Statistics, nothing went into the
job queue. This problem seems to occur consistently with highly used templates.

My guess is that the query used to find pages to update and/or insert them into
the queue takes too long and gets shot down. This problem defeats the purpose of
the job queue, IMHO...

It's critical to a project of mine that this works (see
http://commons.wikimedia.org/wiki/Commons:License_meta-tags is you like). But
also generally, this causes inconsistency in the database. Since we have this
feature, people have started relying on it...


Version: 1.7.x
Severity: major

Details

Reference
bz5527

Event Timeline

bzimport raised the priority of this task from to High.Nov 21 2014, 9:11 PM
bzimport set Reference to bz5527.

Until a good solution for this is found, it would be nice if at least the table
updates for the template itself would be commited before the job-queue insert is
attempted. That way, the template would at least show up in the right
categories, etc, even if pages including the template do not get re-parsed.

I got a "Zero Sized Reply" :/ on PD-old but the edit got through:
http://commons.wikimedia.org/w/index.php?title=Template:PD-old&diff=1999686&oldid=1775931

no dberror in our logs :(

The jobqueue should be populated (at least now), each job row is committed individually

OK, have a fix for this. I'll commit after some more testing.

ayg wrote:

Reverted by siebrand in r40472, caused division by zero.

ayg wrote:

But it was re-reverted by Aaron in r40745, so I discover once again that I should read through *all* my e-mail before believing any of it. :P

brad9626 wrote:

How come this is marked as FIXED? It's still a problem on Commons. Is the fix in a newer version?