Page MenuHomePhabricator

Wikipedia default edit toolbar not displaying button images
Closed, DeclinedPublic

Assigned To
None
Authored By
bzimport
Apr 28 2006, 7:02 PM
Referenced Files
F2776: bug_5747.patch
Nov 21 2014, 9:12 PM
F2774: capture.wikimedia.20060829.1704.txt
Nov 21 2014, 9:12 PM
F2775: capture.oo-doc.20060829.1710.txt
Nov 21 2014, 9:12 PM
F2773: extensionsdialog.gif
Nov 21 2014, 9:12 PM
F2772: buttonsalone.gif
Nov 21 2014, 9:12 PM
F2770: toolbarbug.gif
Nov 21 2014, 9:12 PM

Description

Author: nagle

Description:
The Wikipedia default edit toolbar is not displaying button images. Reloaded
page, reloaded Firefox, cleared cache, upgraded Firefox to latest 1.5.0.2 - no
improvement. Problem first appeared about two weeks ago.


Version: unspecified
Severity: normal
OS: Windows 2000
Platform: PC

Details

Reference
bz5747

Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 21 2014, 9:12 PM
bzimport set Reference to bz5747.
bzimport added a subscriber: Unknown Object (MLST).

Works fine for everyone else. Please provide details such as:

  1. presence of any local "windows firewall" etc
  2. which skin is selected in preferences
  3. any custom javascript on your account
  4. under what circumstances you have tested

nagle wrote:

Developer claims "Works fine for everyone else". Please verify.

Works in: Mozilla Firebird 0.7+ on QNX 6.21
Does not work in: Mozilla Firefox 1.5 on Windows 2000.
Does not work in: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.0.2)
Gecko/20060308 Firefox/1.5.0.2. Upgrade did NOT help.

  1. No "Windows firewall" is present on Windows 2000 machine.
  2. Default skin.
  3. No custom javascript on Wikipedia account.
  4. Browser plugins: FlashBlock. Repeated trials over a week. Worked until

roughly mid-April.

Works fine in Mozilla Firefox 1.5.0.2 on Mac OS X 10.4.

Installed FlashBlock extension (1.33), they still work.

Please provide a screen shot if possible, and confirm that JavaScript is enabled.

nagle wrote:

Screen shot of all-text toolbar

As requested, here's a screen shot of the text-only toolbar.
Javascript is enabled, and in fact, the text buttons in the toolbar work
correctly. But the images won't display.

Attached:

toolbarbug.gif (768×1 px, 82 KB)

I can only reproduce a similar behaviour if i disable images. But then the buddy
icon nor the wikipedia logo would appear!

Does it correctly handle that png images? That wouldn't be a satisfactory
explanation as http://en.wikipedia.org/images/wiki-en.png is png but could lead
us somewhere.

On the other hand, you could see them before :S Try to see the images without
the toolbar: http://en.wikipedia.org/skins-1.5/common/images/button_bold.png
http://upload.wikimedia.org/wikipedia/en/c/c8/Button_redirect.png

marco wrote:

It depends on server load. When it is too heavy, sewrver denies image delivery.

nagle wrote:

Button images as displayed in Firefox

The button images are readable in my browser when read directly, but not when
via the toolbar Javascript. See attached screenshot. So the images are valid,
they're being read OK, they're in the browser's cache OK, the image site isn't
blocked, and Firefox can display them. They just won't display in the toolbar.

Attached:

buttonsalone.gif (348×651 px, 20 KB)

Still works absolutely here in Firefox on Windows XP. The fact that you
can load the images fine lends credence to it being some sort of extension
on your end that's breaking things deliberately.

Can you show a screenshot of your extensions dialog to confirm what's
installed and what versions?

nagle wrote:

Firefox extensions dialog for failing browser

As requested, the extensions dialog for the failing browser.
(What's so striking about all this is that it all worked fine until about a
week ago.)

Attached:

extensionsdialog.gif (392×560 px, 17 KB)

It was also reported at spanuich village pump on 2nd May. Using sistema Windows
2000 too.
I pointed him here, but seems it didn't come.
http://es.wikipedia.org/wiki/Wikipedia:Caf%C3%A9_%28ayuda%29#Desaparici.C3.B3n_barra_de_edici.C3.B3n

John, can you do this for me?

  1. Clear cache and clear your cookie for en.wikipedia.org.
  2. Install "Live HTTP Headers" extension

(from http://livehttpheaders.mozdev.org/ )

  1. Open up 'Live HTTP Headers' window from the Tools menu
  2. Click the 'Config' tab
  3. Uncheck 'Exclude URLs with regexp'
  4. Leave the window open, but click over to a regular Firefox window.
  5. Go to http://en.wikipedia.org/w/index.php?title=Wikipedia:Sandbox&action=edit
  6. Go back to the 'Live HTTP headers' window, click on the 'Headers' tab
  7. Click 'Save All...' to save the recorded HTTP data to a file.
  8. Attach the file here.

nagle wrote:

Sorry, we don't install browser extensions. Perhaps if you asked on Wikipedia
Village Pump you might find someone willing to do this.

You seemed to have no problem with installing Flashblock
(visible in your screen shot) yet you're not willing to
help diagnose the problem you keep complaining about?

hfreville wrote:

Capture of HTTP Headers

attachment capture.wikimedia.20060829.1608.txt ignored as obsolete

Make a full refresh (Ctrl+F5). You should be loading a lot more items
(page+images+scripts+css...)

hfreville wrote:

Capture of HTTP Headers

Attached:

hfreville wrote:

Capture of HTTP Headers from private mediawiki server

This is the traffic between firefox and "my" private mediawiki(1.7) server

The "toolbar" problem only apears only on my firefox (1.5.0.6) on windows XP
(firefox (1.5.0.6) on another computer have no problem)

Maybe, the problem is related to flashblock
I also use this extension, i tried to disabled and uninstalled it
but with no effects
Maybe, flashblock change some firefox files which are not restored upon
uninstall

Attached:

It seems you have a proxy between you and the server. This proxy is probably
called http://isa-4.oddo.fr/ It is stopping you once and again from delivering
the data, asking for authentication. Then your broser autentifies and is 'logged
in' for a couple of requests. Then the proxy asks for auth again...

For pages you authenticate and it works. For images, you authentiate but the
proxy denies authentication. However, some images pass the third time.

This proxy is a good candidate for being guilty.

Your brwser doesn't seem to _ask_ for the images so it could also be the js is
not properly giving it to you. Does flashblock (or any other extension you use)
have the ability to change you browser identification? (what matters is in front
of javascript, not user-agent). As the toolbar is conditionally added, could
also be of importance (but then you shouldn't see the toolbar at all! :S)

hfreville wrote:

I saw the proxy messages in the capture id=2283
so i created the capture id=2284 where no proxy are involved

I'dont know a lot about flashblock, but i don't think it change my browser
identification.
I installed User Agent Switcher and switching my identification to
InternetExplorer 6
doesn't change anything :-(

I'll try to find a computer where i can test if flashblock is responsible or not

nagle wrote:

Here's the problem, and how to fix it.

Those buttons are no longer part of the static page; they're being added by
JavaScript code. That's not always allowed.

Firefox can be in a configuration state where trying to change the "src"
attribute of an "img" element is prohibited. No JavaScript error is reported,
but the change does not take place. If "dom.disable_image_src_set" is set to
"true" in "about.config", such changes are prohibited, and the buttons will
disappear. Google Maps won't work. either.

This is likely to have happened for users who upgraded from Firefox 1.0 to 1.5
or 2. Firefox 1.0 had an options check box which controlled this configuration
parameter, as part of some early attempts at ad filtering. That option check
box was removed in 1.5, but users who upgraded from 1.0 are then stuck at their
old setting. The Firefox upgrader didn't handle this well.

If you open "about:config", find "dom.disable_image_src_set", and reset it to
the default value ("false"), the buttons should reappear.

Ref: http://kb.mozillazine.org/Images_or_animations_don%27t_load

Can this be marked as resolved now?

Check for dom.disable_image_src_set

I don't think so. It's still the same issue if someone has dom.disable_image_src_set to true (although few people will do now).
I think this should be reported upstream. It's a Firefox bug that the image src can't be set before it is attached to the document DOM.

What we can do is to detect the problem and show an error message. I attach a proposal. It just shows a hardcoded string on the toolbar if it was unable to set the src property of the image, it's so uncommon it isn't worth to localize.

Attached:

WONTFIX - This appears to only apply to ancient versions of Firefox and people with odd custom settings, I don't see why we should go out of our way to support this.