Page MenuHomePhabricator

Extra Hooks for $personal_urls
Closed, ResolvedPublic

Assigned To
None
Authored By
bzimport
May 3 2006, 7:21 PM
Referenced Files
F2813: doc.patch
Nov 21 2014, 9:13 PM
F2812: ST.patch
Nov 21 2014, 9:13 PM
F2811: SkinTemplate.patch
Nov 21 2014, 9:13 PM
F2810: hookdoc.patch
Nov 21 2014, 9:13 PM

Description

Author: d1capelis

Description:
I'm currently working on an extension to integrate Shibboleth
(http://shibboleth.internet2.edu/) and Mediawiki and it would be great if
MediaWiki had some hooks to add to $personal_urls.

A patch to SkinTemplate.php and hooks.txt will be included in with this bug to
do this shortly.


Version: unspecified
Severity: enhancement

Details

Reference
bz5819

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 9:13 PM
bzimport set Reference to bz5819.
bzimport added a subscriber: Unknown Object (MLST).

d1capelis wrote:

Patch against 1.6.3 SkinTemplate

attachment SkinTemplate.patch ignored as obsolete

d1capelis wrote:

Patch against 1.6.3 hooks.txt

attachment hooktxt.patch ignored as obsolete

robchur wrote:

Any chance these patches could be provided in unified diff format against SVN trunk?

d1capelis wrote:

Probably should have just done that in the first place... sorry about that.

d1capelis wrote:

Patch against trunk/phase3/docs/hooks.txt

Attached:

d1capelis wrote:

Patch against trunk/phase3/includes/SkipTemplate.php

Attached:

robchur wrote:

I'd be inclined to suggest using the one hook, called after the defaults had
been added.

d1capelis wrote:

That's all I'm using anyways, I just figured adding one before would allow for
more flexibility, regardless, here's a patch to use one hook instead.

d1capelis wrote:

Modified version of patch 1659 with only one hook

attachment ST.patch ignored as obsolete

d1capelis wrote:

Modified version of patch 1659 with only one hook (Correct)

I was editing my previous patch with vim... apparently it's helpful if you edit
the patch correctly. :-\

Attached:

d1capelis wrote:

Modified version of patch 1658 with only one hook

And here's the modified documentation changes.

Attached:

robchur wrote:

Applied a modified form in SVN trunk, r13138.

robchur wrote:

(In reply to comment #12)

Applied a modified form in SVN trunk, r13138.

That's r14138, excuse me.

d1capelis wrote:

Modified form has a flaw:

Line was modified to:
wfRunHooks( 'PersonalUrls', array( $personal_urls, $wgTitle ) );

Should be:
wfRunHooks( 'PersonalUrls', array( &$personal_urls, $wgTitle ) );

If we can get this last character corrected that would be great.

robchur wrote:

Argh. Fixed in SVN trunk, r14261.

d1capelis wrote:

Fix and hook verified, thanks again. :)