Page MenuHomePhabricator

Renameuser does not update the `archive` table
Closed, ResolvedPublic

Description

Author: yaohua2000

Description:
See the log:
http://en.wikipedia.org/w/index.php?title=Special:Log&user=Yaohua2000

See the contribution:
http://en.wikipedia.org/wiki/Special:Contributions/Yaohua2000

A user created on April 14, 2006 made an edit on October 25, 2005.

What cause this problem is that the article had been deleted but undeleted
recently, User:Yaohua2000 renamed before the undeletion.

Please fix the bug.


Version: unspecified
Severity: normal

Details

Reference
bz5930

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 9:14 PM
bzimport set Reference to bz5930.
bzimport added a subscriber: Unknown Object (MLST).

robchur wrote:

The Renameuser extension has the lines which would change the archive table
commented out, apparently for performance reasons.

ayg wrote:

*** Bug 9020 has been marked as a duplicate of this bug. ***

rotemliss wrote:

It is not updated by purpose - see r13413. Introducing some better indexes for
this table instead of disabling the updates may be better, though.

robchur wrote:

Note that RenameUser can now be configured to update this table; the default for
this option is the same as $wgMiserMode, so on sites where expensive operations
are switched off, so will archive table updates be. This can be overridden, of
course.

ayg wrote:

*** Bug 10048 has been marked as a duplicate of this bug. ***

ayg wrote:

(From bug 10048 comment #1)

There is no usertext index on the archive table, so renaming deleted edits
would be a performance issue.

Why can't we just add such an index? Surely archive is vastly smaller than revision.

(In reply to comment #6)

(From bug 10048 comment #1)

There is no usertext index on the archive table, so renaming deleted edits
would be a performance issue.

Why can't we just add such an index? Surely archive is vastly smaller than
revision.

Adding an index would enable my deletecontributions extension too :)

However see http://www.mediawiki.org/wiki/Extension_talk:DeletedContributions.

ayg wrote:

(In reply to comment #7)

However see http://www.mediawiki.org/wiki/Extension_talk:DeletedContributions.

I.e., "schema updates are disruptive". Well, yeah. :) It can still be put in line with the other updates. And it's not like rev_deleted is going to instantly phase out the archive table in the next month or something.

  • Zscout370 deleted own talk page over "HD DVD code pasted there several times"

which has been overnighted out by now probably

http://en.wikipedia.org/w/index.php?title=Special%3ALog&type=delete&user=&page=User+talk%3AZscout370

  • Raul654 renamed my account from Cool_Cat -> White_Cat

http://en.wikipedia.org/w/index.php?title=Special%3ALog&type=renameuser&user=Raul654&page=

  • Zscout370 restored his talk page after the move

http://en.wikipedia.org/w/index.php?title=Special%3ALog&type=delete&user=&page=User+talk%3AZscout370

  • User:Cool_Cat has some of User:White_Cat's contributions now:

http://en.wikipedia.org/wiki/Special:Contributions/Cool_Cat


I believe this is a bug. Deleted edits do not seem to be properly "renamed". It
may be unique to the case so additional review is necessary.

ayg wrote:

No it's not. The issue is known and the exact solution necessary is known. An index has to be added to the appropriate column of the archive table and the code has to be updated accordingly. Go bother Tim or someone about adding that index if you want.

As with enabled deletedcontribs extension, will wait until schema change done.

robchur wrote:

This is an active bug; the schema change is a dependency. The bug is not resolved until the schema change is done and all relevant code is updated.

It is fixed, but for renames from now on.
Although now that it's indexed, shouldn't be hard to do old renamings on request.

I see, can all past renames be processed? This is particularly important for licensing related reasons among other things.

  • White Cat