Page MenuHomePhabricator

Upload directory can trigger false positive on ad blockers
Closed, ResolvedPublic

Description

Author: phlipping

Description:
The current upload code will occasionally decide to upload a file to
$wgUploadPath/a/ad/filename.png - the "/ad/" in that path will trigger some
simple advertising blockers, leaving some users unable to see the image (or even
Media: links to it). This could rather easily be fixed by testing if the path
chosen is /a/ad/ and returning another path instead, perhaps just /a/d/ or
something similar... though it would have to be changed in several places, I see
it 4 times in Image.php alone...

Admittedly, fixing this would break most existing MediaWiki installations, as
all the images in the /a/ad/ dir will have to be moved (probably by hand) to
wherever the fixed upload code says they should belong... I suppose it's one for
the powers that be to decide if it should be fixed.


Version: 1.6.x
Severity: normal

Details

Reference
bz6020

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 9:17 PM
bzimport set Reference to bz6020.
bzimport added a subscriber: Unknown Object (MLST).
  • This bug has been marked as a duplicate of 5402 ***

phlipping wrote:

Yeah, OK, sorry, it's a hard bug to search for... ;)